Skip to content
Snippets Groups Projects
Select Git revision
  • master default protected
  • 12-9-stable
  • 12-7-stable
  • 12-6-stable
  • 12-8-stable
  • github/fork/Kloppi313/patch-1
  • 12-5-stable
  • 12-4-stable
  • github/fork/ramalokesh8477/master
  • 12-1-stable
  • 12-2-stable
  • 12-0-stable
  • 12-3-stable
  • 42-42-stable
  • github/fork/hussamgit398/patch-2
  • 12-3-auto-deploy-20190911
  • 12-3-auto-deploy-20190916
  • 12-3-auto-deploy-20190908
  • 12-3-auto-deploy-20190901
  • 12-3-auto-deploy-20190901-32664
  • v12.10.0.pre
  • v12.9.0
  • v12.9.0-rc42
  • v12.8.7
  • v12.8.6
  • v12.8.5
  • v12.8.4
  • v12.8.3
  • v12.6.8
  • v12.7.7
  • v12.8.2
  • v12.8.1
  • v12.9.0.pre
  • v12.8.0
  • v12.8.0-rc42
  • v12.5.10
  • v12.7.6
  • v12.6.7
  • v12.7.5
  • v12.5.9
40 results

notes_actions.rb

  • Markus Koller's avatar
    12d7b393
    Correctly check permissions when creating snippet notes · 12d7b393
    Markus Koller authored
    In the Snippets::NotesController the noteable was resolved and
    authorized through the :snippet_id, so by passing a :target_id for a
    different snippet it was possible to create a note on a snippet
    where the user would be unauthorized to do so otherwise.
    
    This fixes the problem by ignoring the :target_id and :target_type from
    the request, and using the same noteable for creation and authorization.
    Correctly check permissions when creating snippet notes
    Markus Koller authored
    In the Snippets::NotesController the noteable was resolved and
    authorized through the :snippet_id, so by passing a :target_id for a
    different snippet it was possible to create a note on a snippet
    where the user would be unauthorized to do so otherwise.
    
    This fixes the problem by ignoring the :target_id and :target_type from
    the request, and using the same noteable for creation and authorization.