Skip to content
Snippets Groups Projects
Select Git revision
  • master default protected
  • 12-9-stable
  • 12-7-stable
  • 12-6-stable
  • 12-8-stable
  • github/fork/Kloppi313/patch-1
  • 12-5-stable
  • 12-4-stable
  • github/fork/ramalokesh8477/master
  • 12-1-stable
  • 12-2-stable
  • 12-0-stable
  • 12-3-stable
  • 42-42-stable
  • github/fork/hussamgit398/patch-2
  • 12-3-auto-deploy-20190911
  • 12-3-auto-deploy-20190916
  • 12-3-auto-deploy-20190908
  • 12-3-auto-deploy-20190901
  • 12-3-auto-deploy-20190901-32664
  • v12.10.0.pre
  • v12.9.0
  • v12.9.0-rc42
  • v12.8.7
  • v12.8.6
  • v12.8.5
  • v12.8.4
  • v12.8.3
  • v12.6.8
  • v12.7.7
  • v12.8.2
  • v12.8.1
  • v12.9.0.pre
  • v12.8.0
  • v12.8.0-rc42
  • v12.5.10
  • v12.7.6
  • v12.6.7
  • v12.7.5
  • v12.5.9
40 results

build_service.rb

  • Rydkin Maxim's avatar
    14326c88
    refactor merge request build service · 14326c88
    Rydkin Maxim authored
    add changelog entry
    
    replace local variables `merge_request` with instance ones
    
    modify `MergeRequests::BuildService` to fix failed tests
    
    extract `assign_target_project` method
    
    remove unnecessary instance variables
    
    remove exclamation marks and rewrite conditionals to improve readability
    
    extract `params_does_not_contain_branches?` method, rename `unprepared_merge_request` method to `uncreatable_merge_request`
    
    replace instance variables `merge_request` and `error_messages` with getters and setters; divide `set_title_and_description` method on two separate ones
    
    refactor `execute` method
    
    return `set_title_and_description` method
    
    rename `branches_selected?` method to `branches_present?` to make it more different from `branches_specified?`
    
    fixes after discussion
    
    renamed method branches_valid?
    
    fix space
    
    return assigning methods into `execute` method
    
    simplify `find_target_branch` and `find_source_project` methods
    
    fix spec `merge request issuable record that supports slash commands in its description and notes`
    14326c88
    History
    refactor merge request build service
    Rydkin Maxim authored
    add changelog entry
    
    replace local variables `merge_request` with instance ones
    
    modify `MergeRequests::BuildService` to fix failed tests
    
    extract `assign_target_project` method
    
    remove unnecessary instance variables
    
    remove exclamation marks and rewrite conditionals to improve readability
    
    extract `params_does_not_contain_branches?` method, rename `unprepared_merge_request` method to `uncreatable_merge_request`
    
    replace instance variables `merge_request` and `error_messages` with getters and setters; divide `set_title_and_description` method on two separate ones
    
    refactor `execute` method
    
    return `set_title_and_description` method
    
    rename `branches_selected?` method to `branches_present?` to make it more different from `branches_specified?`
    
    fixes after discussion
    
    renamed method branches_valid?
    
    fix space
    
    return assigning methods into `execute` method
    
    simplify `find_target_branch` and `find_source_project` methods
    
    fix spec `merge request issuable record that supports slash commands in its description and notes`