Skip to content
Snippets Groups Projects
Select Git revision
  • master default protected
  • 12-9-stable
  • 12-7-stable
  • 12-6-stable
  • 12-8-stable
  • github/fork/Kloppi313/patch-1
  • 12-5-stable
  • 12-4-stable
  • github/fork/ramalokesh8477/master
  • 12-1-stable
  • 12-2-stable
  • 12-0-stable
  • 12-3-stable
  • 42-42-stable
  • github/fork/hussamgit398/patch-2
  • 12-3-auto-deploy-20190911
  • 12-3-auto-deploy-20190916
  • 12-3-auto-deploy-20190908
  • 12-3-auto-deploy-20190901
  • 12-3-auto-deploy-20190901-32664
  • v12.10.0.pre
  • v12.9.0
  • v12.9.0-rc42
  • v12.8.7
  • v12.8.6
  • v12.8.5
  • v12.8.4
  • v12.8.3
  • v12.6.8
  • v12.7.7
  • v12.8.2
  • v12.8.1
  • v12.9.0.pre
  • v12.8.0
  • v12.8.0-rc42
  • v12.5.10
  • v12.7.6
  • v12.6.7
  • v12.7.5
  • v12.5.9
40 results

commit.rb

  • Yorick Peterse's avatar
    19428e80
    Preload pipeline data for project pipelines · 19428e80
    Yorick Peterse authored
    When displaying the pipelines of a project we now preload the following
    data:
    
    1. Authors of the commits that belong to these pipelines
    2. The number of warnings per pipeline, which is used by
       Ci::Pipeline#has_warnings?
    
    == Commit Authors
    
    Previously this data was queried for every Commit separately, leading to
    20 SQL queries being executed in the worst case. With an average of 3 to
    5 milliseconds per SQL query this could result in 100 milliseconds being
    spent in _just_ getting Commit authors.
    
    To preload this data Commit#author now uses BatchLoader (through
    Commit#lazy_author), and a separate module
    Gitlab::Ci::Pipeline::Preloader is used to ensure all authors are loaded
    before they are used.
    
    == Number of warnings
    
    This changes Ci::Pipeline#has_warnings? so it supports preloading of the
    number of warnings per pipeline. This removes the need for executing a
    COUNT(*) query for every pipeline just to see if it has any warnings or
    not.
    Preload pipeline data for project pipelines
    Yorick Peterse authored
    When displaying the pipelines of a project we now preload the following
    data:
    
    1. Authors of the commits that belong to these pipelines
    2. The number of warnings per pipeline, which is used by
       Ci::Pipeline#has_warnings?
    
    == Commit Authors
    
    Previously this data was queried for every Commit separately, leading to
    20 SQL queries being executed in the worst case. With an average of 3 to
    5 milliseconds per SQL query this could result in 100 milliseconds being
    spent in _just_ getting Commit authors.
    
    To preload this data Commit#author now uses BatchLoader (through
    Commit#lazy_author), and a separate module
    Gitlab::Ci::Pipeline::Preloader is used to ensure all authors are loaded
    before they are used.
    
    == Number of warnings
    
    This changes Ci::Pipeline#has_warnings? so it supports preloading of the
    number of warnings per pipeline. This removes the need for executing a
    COUNT(*) query for every pipeline just to see if it has any warnings or
    not.