Skip to content
Snippets Groups Projects
Select Git revision
  • master default protected
  • 12-9-stable
  • 12-7-stable
  • 12-6-stable
  • 12-8-stable
  • github/fork/Kloppi313/patch-1
  • 12-5-stable
  • 12-4-stable
  • github/fork/ramalokesh8477/master
  • 12-1-stable
  • 12-2-stable
  • 12-0-stable
  • 12-3-stable
  • 42-42-stable
  • github/fork/hussamgit398/patch-2
  • 12-3-auto-deploy-20190911
  • 12-3-auto-deploy-20190916
  • 12-3-auto-deploy-20190908
  • 12-3-auto-deploy-20190901
  • 12-3-auto-deploy-20190901-32664
  • v12.10.0.pre
  • v12.9.0
  • v12.9.0-rc42
  • v12.8.7
  • v12.8.6
  • v12.8.5
  • v12.8.4
  • v12.8.3
  • v12.6.8
  • v12.7.7
  • v12.8.2
  • v12.8.1
  • v12.9.0.pre
  • v12.8.0
  • v12.8.0-rc42
  • v12.5.10
  • v12.7.6
  • v12.6.7
  • v12.7.5
  • v12.5.9
40 results

notification_service_spec.rb

  • Pierre de La Morinerie's avatar
    2729bdf3
    Don't send an email for "mentioned in" notes · 2729bdf3
    Pierre de La Morinerie authored and Marin Jankovski's avatar Marin Jankovski committed
    Currently, an email is sent every time a mentionable is referenced
    by an issue, a commit or a merge request: if I comment "This MR is
    related to #5", watchers get one email for the comment, and another
    one stating "Issue #5 was mentioned by issue #13".
    
    This is annoying — but the biggest issue is when pushing an existing
    branch. Every issue referenced by commit messages in this branch will
    get a new mention (which is fine), and dozens of emails will be sent
    for all these new mentions (which is not).
    
    This commit fixes the spam by avoiding to send an email when a new
    mention is created. In most cases the email notification for the
    mentioner is enough.
    2729bdf3
    History
    Don't send an email for "mentioned in" notes
    Pierre de La Morinerie authored and Marin Jankovski's avatar Marin Jankovski committed
    Currently, an email is sent every time a mentionable is referenced
    by an issue, a commit or a merge request: if I comment "This MR is
    related to #5", watchers get one email for the comment, and another
    one stating "Issue #5 was mentioned by issue #13".
    
    This is annoying — but the biggest issue is when pushing an existing
    branch. Every issue referenced by commit messages in this branch will
    get a new mention (which is fine), and dozens of emails will be sent
    for all these new mentions (which is not).
    
    This commit fixes the spam by avoiding to send an email when a new
    mention is created. In most cases the email notification for the
    mentioner is enough.