Skip to content
Snippets Groups Projects
Select Git revision
  • master default protected
  • 12-9-stable
  • 12-7-stable
  • 12-6-stable
  • 12-8-stable
  • github/fork/Kloppi313/patch-1
  • 12-5-stable
  • 12-4-stable
  • github/fork/ramalokesh8477/master
  • 12-1-stable
  • 12-2-stable
  • 12-0-stable
  • 12-3-stable
  • 42-42-stable
  • github/fork/hussamgit398/patch-2
  • 12-3-auto-deploy-20190911
  • 12-3-auto-deploy-20190916
  • 12-3-auto-deploy-20190908
  • 12-3-auto-deploy-20190901
  • 12-3-auto-deploy-20190901-32664
  • v12.10.0.pre
  • v12.9.0
  • v12.9.0-rc42
  • v12.8.7
  • v12.8.6
  • v12.8.5
  • v12.8.4
  • v12.8.3
  • v12.6.8
  • v12.7.7
  • v12.8.2
  • v12.8.1
  • v12.9.0.pre
  • v12.8.0
  • v12.8.0-rc42
  • v12.5.10
  • v12.7.6
  • v12.6.7
  • v12.7.5
  • v12.5.9
40 results

commit.rb

  • Stan Hu's avatar
    29ce13e9
    Fix moving issues API failing when text includes commit URLs · 29ce13e9
    Stan Hu authored
    When a issue is moved from one project to another, all associated
    Markdown text is rewritten in the context of the new project. If the
    note contained a link to a commit URL, `CommitRewriter#rewrite` would
    fail because `Commit#link_reference_pattern` would match `nil` `commit`
    values in the HTML generated from the Markdown. These `nil` values were
    passed along to `Project#commits_by` because `Commit#reference_valid?`
    was always returning `true`.
    
    To prevent this issue from happening, we tighten up the check for
    `Commit#reference_valid?` to look for valid SHA values.
    
    Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/66666
    29ce13e9
    History
    Fix moving issues API failing when text includes commit URLs
    Stan Hu authored
    When a issue is moved from one project to another, all associated
    Markdown text is rewritten in the context of the new project. If the
    note contained a link to a commit URL, `CommitRewriter#rewrite` would
    fail because `Commit#link_reference_pattern` would match `nil` `commit`
    values in the HTML generated from the Markdown. These `nil` values were
    passed along to `Project#commits_by` because `Commit#reference_valid?`
    was always returning `true`.
    
    To prevent this issue from happening, we tighten up the check for
    `Commit#reference_valid?` to look for valid SHA values.
    
    Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/66666