Skip to content
Snippets Groups Projects
Select Git revision
  • master default protected
  • 12-9-stable
  • 12-7-stable
  • 12-6-stable
  • 12-8-stable
  • github/fork/Kloppi313/patch-1
  • 12-5-stable
  • 12-4-stable
  • github/fork/ramalokesh8477/master
  • 12-1-stable
  • 12-2-stable
  • 12-0-stable
  • 12-3-stable
  • 42-42-stable
  • github/fork/hussamgit398/patch-2
  • 12-3-auto-deploy-20190911
  • 12-3-auto-deploy-20190916
  • 12-3-auto-deploy-20190908
  • 12-3-auto-deploy-20190901
  • 12-3-auto-deploy-20190901-32664
  • v12.10.0.pre
  • v12.9.0
  • v12.9.0-rc42
  • v12.8.7
  • v12.8.6
  • v12.8.5
  • v12.8.4
  • v12.8.3
  • v12.6.8
  • v12.7.7
  • v12.8.2
  • v12.8.1
  • v12.9.0.pre
  • v12.8.0
  • v12.8.0-rc42
  • v12.5.10
  • v12.7.6
  • v12.6.7
  • v12.7.5
  • v12.5.9
40 results

repository.rb

  • Nick Thomas's avatar
    034f0340
    Don't use the redis set cache yet · 034f0340
    Nick Thomas authored
    For zero-downtime deployed in a mixed code environment between 12.2 and
    12.3, the branch and tag name cache is incorrectly invalidated - a push
    to an old machine will not clear the redis set version of the cache on
    the new machine.
    
    This commit ensures that, in 12.3, both set and non-set versions of the
    cache are invalidated, but does not write or consult the set version of
    the cache. . In 12.4, it will be safe to switch branch and tag names to
    the redis set cache both it and the legacy cache will be invalidated
    appropriately in such a mixed code environment.
    
    This delays the full implementation of the feature by one release, but
    in the absence of a credible feature-flagging strategy, and amidst an
    abundance of caution about the effects of too-eager cache expiration, I
    believe this is the best approach available to us.
    Verified
    034f0340
    History
    Don't use the redis set cache yet
    Nick Thomas authored
    For zero-downtime deployed in a mixed code environment between 12.2 and
    12.3, the branch and tag name cache is incorrectly invalidated - a push
    to an old machine will not clear the redis set version of the cache on
    the new machine.
    
    This commit ensures that, in 12.3, both set and non-set versions of the
    cache are invalidated, but does not write or consult the set version of
    the cache. . In 12.4, it will be safe to switch branch and tag names to
    the redis set cache both it and the legacy cache will be invalidated
    appropriately in such a mixed code environment.
    
    This delays the full implementation of the feature by one release, but
    in the absence of a credible feature-flagging strategy, and amidst an
    abundance of caution about the effects of too-eager cache expiration, I
    believe this is the best approach available to us.