Skip to content
Snippets Groups Projects
Select Git revision
  • master default protected
  • 12-9-stable
  • 12-7-stable
  • 12-6-stable
  • 12-8-stable
  • github/fork/Kloppi313/patch-1
  • 12-5-stable
  • 12-4-stable
  • github/fork/ramalokesh8477/master
  • 12-1-stable
  • 12-2-stable
  • 12-0-stable
  • 12-3-stable
  • 42-42-stable
  • github/fork/hussamgit398/patch-2
  • 12-3-auto-deploy-20190911
  • 12-3-auto-deploy-20190916
  • 12-3-auto-deploy-20190908
  • 12-3-auto-deploy-20190901
  • 12-3-auto-deploy-20190901-32664
  • v12.10.0.pre
  • v12.9.0
  • v12.9.0-rc42
  • v12.8.7
  • v12.8.6
  • v12.8.5
  • v12.8.4
  • v12.8.3
  • v12.6.8
  • v12.7.7
  • v12.8.2
  • v12.8.1
  • v12.9.0.pre
  • v12.8.0
  • v12.8.0-rc42
  • v12.5.10
  • v12.7.6
  • v12.6.7
  • v12.7.5
  • v12.5.9
40 results

close_service.rb

  • Yorick Peterse's avatar
    57b96eb6
    Fix refreshing of issues/MR count caches · 57b96eb6
    Yorick Peterse authored
    This ensures the open issues/MR count caches are refreshed properly when
    creating new issues or MRs. This MR also includes a change to the cache
    keys to ensure all caches are rebuilt on the fly.
    
    This particular problem was not caught in the test suite due to a null
    cache being used, resulting in all calls that would use a cache using
    the underlying data directly. In production the code would fail because
    a newly saved record returns an empty hash in #changes meaning checks
    such as `state_changed? || confidential_changed?` would return false for
    new rows, thus never updating the counters.
    
    Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/38061
    Verified
    57b96eb6
    History
    Fix refreshing of issues/MR count caches
    Yorick Peterse authored
    This ensures the open issues/MR count caches are refreshed properly when
    creating new issues or MRs. This MR also includes a change to the cache
    keys to ensure all caches are rebuilt on the fly.
    
    This particular problem was not caught in the test suite due to a null
    cache being used, resulting in all calls that would use a cache using
    the underlying data directly. In production the code would fail because
    a newly saved record returns an empty hash in #changes meaning checks
    such as `state_changed? || confidential_changed?` would return false for
    new rows, thus never updating the counters.
    
    Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/38061