Skip to content
Snippets Groups Projects
Select Git revision
  • master default protected
  • 12-9-stable
  • 12-7-stable
  • 12-6-stable
  • 12-8-stable
  • github/fork/Kloppi313/patch-1
  • 12-5-stable
  • 12-4-stable
  • github/fork/ramalokesh8477/master
  • 12-1-stable
  • 12-2-stable
  • 12-0-stable
  • 12-3-stable
  • 42-42-stable
  • github/fork/hussamgit398/patch-2
  • 12-3-auto-deploy-20190911
  • 12-3-auto-deploy-20190916
  • 12-3-auto-deploy-20190908
  • 12-3-auto-deploy-20190901
  • 12-3-auto-deploy-20190901-32664
  • v12.10.0.pre
  • v12.9.0
  • v12.9.0-rc42
  • v12.8.7
  • v12.8.6
  • v12.8.5
  • v12.8.4
  • v12.8.3
  • v12.6.8
  • v12.7.7
  • v12.8.2
  • v12.8.1
  • v12.9.0.pre
  • v12.8.0
  • v12.8.0-rc42
  • v12.5.10
  • v12.7.6
  • v12.6.7
  • v12.7.5
  • v12.5.9
40 results

projects_helper.rb

  • Sean McGivern's avatar
    5883ce95
    `current_application_settings` belongs on `Gitlab::CurrentSettings` · 5883ce95
    Sean McGivern authored
    The initializers including this were doing so at the top level, so every object
    loaded after them had a `current_application_settings` method. However, if
    someone had rack-attack enabled (which was loaded before these initializers), it
    would try to load the API, and fail, because `Gitlab::CurrentSettings` didn't
    have that method.
    
    To fix this:
    
    1. Don't include `Gitlab::CurrentSettings` at the top level. We do not need
       `Object.new.current_application_settings` to work.
    2. Make `Gitlab::CurrentSettings` explicitly `extend self`, as we already use it
       like that in several places.
    3. Change the initializers to use that new form.
    5883ce95
    History
    `current_application_settings` belongs on `Gitlab::CurrentSettings`
    Sean McGivern authored
    The initializers including this were doing so at the top level, so every object
    loaded after them had a `current_application_settings` method. However, if
    someone had rack-attack enabled (which was loaded before these initializers), it
    would try to load the API, and fail, because `Gitlab::CurrentSettings` didn't
    have that method.
    
    To fix this:
    
    1. Don't include `Gitlab::CurrentSettings` at the top level. We do not need
       `Object.new.current_application_settings` to work.
    2. Make `Gitlab::CurrentSettings` explicitly `extend self`, as we already use it
       like that in several places.
    3. Change the initializers to use that new form.