Skip to content
Snippets Groups Projects
Select Git revision
  • master default protected
  • 12-9-stable
  • 12-7-stable
  • 12-6-stable
  • 12-8-stable
  • github/fork/Kloppi313/patch-1
  • 12-5-stable
  • 12-4-stable
  • github/fork/ramalokesh8477/master
  • 12-1-stable
  • 12-2-stable
  • 12-0-stable
  • 12-3-stable
  • 42-42-stable
  • github/fork/hussamgit398/patch-2
  • 12-3-auto-deploy-20190911
  • 12-3-auto-deploy-20190916
  • 12-3-auto-deploy-20190908
  • 12-3-auto-deploy-20190901
  • 12-3-auto-deploy-20190901-32664
  • v12.10.0.pre
  • v12.9.0
  • v12.9.0-rc42
  • v12.8.7
  • v12.8.6
  • v12.8.5
  • v12.8.4
  • v12.8.3
  • v12.6.8
  • v12.7.7
  • v12.8.2
  • v12.8.1
  • v12.9.0.pre
  • v12.8.0
  • v12.8.0-rc42
  • v12.5.10
  • v12.7.6
  • v12.6.7
  • v12.7.5
  • v12.5.9
40 results

todo_service_spec.rb

Blame
  • Nick Thomas's avatar
    1e6765db
    Send TODOs for comments on commits correctly · 1e6765db
    Nick Thomas authored
    At present, the TodoService uses the `:read_project` ability to decide
    whether a user can read a note on a commit. However, commits can have a
    visibility level that is more restricted than the project, so this is a
    security issue.
    
    This commit changes the code to use the `:read_commit` ability in this
    case instead, which ensures TODOs are only generated for commit notes
    if the users can see the commit.
    Verified
    1e6765db
    History
    Send TODOs for comments on commits correctly
    Nick Thomas authored
    At present, the TodoService uses the `:read_project` ability to decide
    whether a user can read a note on a commit. However, commits can have a
    visibility level that is more restricted than the project, so this is a
    security issue.
    
    This commit changes the code to use the `:read_commit` ability in this
    case instead, which ensures TODOs are only generated for commit notes
    if the users can see the commit.