Skip to content
Snippets Groups Projects
Select Git revision
  • master default protected
  • 12-9-stable
  • 12-7-stable
  • 12-6-stable
  • 12-8-stable
  • github/fork/Kloppi313/patch-1
  • 12-5-stable
  • 12-4-stable
  • github/fork/ramalokesh8477/master
  • 12-1-stable
  • 12-2-stable
  • 12-0-stable
  • 12-3-stable
  • 42-42-stable
  • github/fork/hussamgit398/patch-2
  • 12-3-auto-deploy-20190911
  • 12-3-auto-deploy-20190916
  • 12-3-auto-deploy-20190908
  • 12-3-auto-deploy-20190901
  • 12-3-auto-deploy-20190901-32664
  • v12.10.0.pre
  • v12.9.0
  • v12.9.0-rc42
  • v12.8.7
  • v12.8.6
  • v12.8.5
  • v12.8.4
  • v12.8.3
  • v12.6.8
  • v12.7.7
  • v12.8.2
  • v12.8.1
  • v12.9.0.pre
  • v12.8.0
  • v12.8.0-rc42
  • v12.5.10
  • v12.7.6
  • v12.6.7
  • v12.7.5
  • v12.5.9
40 results

admin_settings_spec.rb

  • Stan Hu's avatar
    681af5bc
    Fix Error 500 when application settings are saved · 681af5bc
    Stan Hu authored
    Due to a Rails bug, fetching the application settings from Redis
    may prevent the attribute methods from being loaded for the `ApplicationSetting`
    model. More details here: https://github.com/rails/rails/issues/27348
    
    There was also a secondary problem introduced by overriding these
    association methods which caused all default visibility levels to be
    set to `nil`. Before, the previous implementation allowed the string
    "20" to be saved as an integer, while now a table lookup happens
    before that. We fix this by enforcing the integer value in the
    controller and default to PRIVATE.
    
    Closes #29674
    681af5bc
    History
    Fix Error 500 when application settings are saved
    Stan Hu authored
    Due to a Rails bug, fetching the application settings from Redis
    may prevent the attribute methods from being loaded for the `ApplicationSetting`
    model. More details here: https://github.com/rails/rails/issues/27348
    
    There was also a secondary problem introduced by overriding these
    association methods which caused all default visibility levels to be
    set to `nil`. Before, the previous implementation allowed the string
    "20" to be saved as an integer, while now a table lookup happens
    before that. We fix this by enforcing the integer value in the
    controller and default to PRIVATE.
    
    Closes #29674