Skip to content
Snippets Groups Projects
Select Git revision
  • master default protected
  • 12-9-stable
  • 12-7-stable
  • 12-6-stable
  • 12-8-stable
  • github/fork/Kloppi313/patch-1
  • 12-5-stable
  • 12-4-stable
  • github/fork/ramalokesh8477/master
  • 12-1-stable
  • 12-2-stable
  • 12-0-stable
  • 12-3-stable
  • 42-42-stable
  • github/fork/hussamgit398/patch-2
  • 12-3-auto-deploy-20190911
  • 12-3-auto-deploy-20190916
  • 12-3-auto-deploy-20190908
  • 12-3-auto-deploy-20190901
  • 12-3-auto-deploy-20190901-32664
  • v12.10.0.pre
  • v12.9.0
  • v12.9.0-rc42
  • v12.8.7
  • v12.8.6
  • v12.8.5
  • v12.8.4
  • v12.8.3
  • v12.6.8
  • v12.7.7
  • v12.8.2
  • v12.8.1
  • v12.9.0.pre
  • v12.8.0
  • v12.8.0-rc42
  • v12.5.10
  • v12.7.6
  • v12.6.7
  • v12.7.5
  • v12.5.9
40 results

move_to_project_finder.rb

  • Yorick Peterse's avatar
    6f3c4901
    Refactor AutocompleteController · 6f3c4901
    Yorick Peterse authored
    This refactors the AutocompleteController according to the guidelines
    and boundaries discussed in
    https://gitlab.com/gitlab-org/gitlab-ce/issues/49653. Specifically,
    ActiveRecord logic is moved to different finders, which are then used in
    the controller. View logic in turn is moved to presenters, instead of
    directly using ActiveRecord's "to_json" method.
    
    The finder MoveToProjectFinder is also adjusted according to the
    abstraction guidelines and boundaries, resulting in a much more simple
    finder.
    
    By using finders (and other abstractions) more actively, we can push a
    lot of logic out of the controller. We also remove the need for various
    "before_action" hooks, though this could be achieved without using
    finders as well.
    
    The various finders related to AutcompleteController have also been
    moved into a namespace. This removes the need for calling everything
    "AutocompleteSmurfFinder", instead you can use
    "Autocomplete::SmurfFinder".
    Verified
    6f3c4901
    History
    Refactor AutocompleteController
    Yorick Peterse authored
    This refactors the AutocompleteController according to the guidelines
    and boundaries discussed in
    https://gitlab.com/gitlab-org/gitlab-ce/issues/49653. Specifically,
    ActiveRecord logic is moved to different finders, which are then used in
    the controller. View logic in turn is moved to presenters, instead of
    directly using ActiveRecord's "to_json" method.
    
    The finder MoveToProjectFinder is also adjusted according to the
    abstraction guidelines and boundaries, resulting in a much more simple
    finder.
    
    By using finders (and other abstractions) more actively, we can push a
    lot of logic out of the controller. We also remove the need for various
    "before_action" hooks, though this could be achieved without using
    finders as well.
    
    The various finders related to AutcompleteController have also been
    moved into a namespace. This removes the need for calling everything
    "AutocompleteSmurfFinder", instead you can use
    "Autocomplete::SmurfFinder".