Skip to content
Snippets Groups Projects
Select Git revision
  • master default protected
  • 12-9-stable
  • 12-7-stable
  • 12-6-stable
  • 12-8-stable
  • github/fork/Kloppi313/patch-1
  • 12-5-stable
  • 12-4-stable
  • github/fork/ramalokesh8477/master
  • 12-1-stable
  • 12-2-stable
  • 12-0-stable
  • 12-3-stable
  • 42-42-stable
  • github/fork/hussamgit398/patch-2
  • 12-3-auto-deploy-20190911
  • 12-3-auto-deploy-20190916
  • 12-3-auto-deploy-20190908
  • 12-3-auto-deploy-20190901
  • 12-3-auto-deploy-20190901-32664
  • v12.10.0.pre
  • v12.9.0
  • v12.9.0-rc42
  • v12.8.7
  • v12.8.6
  • v12.8.5
  • v12.8.4
  • v12.8.3
  • v12.6.8
  • v12.7.7
  • v12.8.2
  • v12.8.1
  • v12.9.0.pre
  • v12.8.0
  • v12.8.0-rc42
  • v12.5.10
  • v12.7.6
  • v12.6.7
  • v12.7.5
  • v12.5.9
40 results

project_team.rb

  • Timothy Andrew's avatar
    7b2ad2d5
    Implement review comments from @dbalexandre. · 7b2ad2d5
    Timothy Andrew authored
    1. Remove `master_or_greater?` and `developer_or_greater?` in favor of
       `max_member_access`, which is a lot nicer.
    
    2. Remove a number of instances of `include Gitlab::Database::MigrationHelpers`
       in migrations that don't need this module. Also remove comments where
       not necessary.
    
    3. Remove duplicate entry in CHANGELOG.
    
    4. Move `ProtectedBranchAccessSelect` from Coffeescript to ES6.
    
    5. Split the `set_access_levels!` method in two - one each for `merge` and
       `push` access levels.
    7b2ad2d5
    History
    Implement review comments from @dbalexandre.
    Timothy Andrew authored
    1. Remove `master_or_greater?` and `developer_or_greater?` in favor of
       `max_member_access`, which is a lot nicer.
    
    2. Remove a number of instances of `include Gitlab::Database::MigrationHelpers`
       in migrations that don't need this module. Also remove comments where
       not necessary.
    
    3. Remove duplicate entry in CHANGELOG.
    
    4. Move `ProtectedBranchAccessSelect` from Coffeescript to ES6.
    
    5. Split the `set_access_levels!` method in two - one each for `merge` and
       `push` access levels.