Skip to content
Snippets Groups Projects
Select Git revision
  • master default protected
  • 12-9-stable
  • 12-7-stable
  • 12-6-stable
  • 12-8-stable
  • github/fork/Kloppi313/patch-1
  • 12-5-stable
  • 12-4-stable
  • github/fork/ramalokesh8477/master
  • 12-1-stable
  • 12-2-stable
  • 12-0-stable
  • 12-3-stable
  • 42-42-stable
  • github/fork/hussamgit398/patch-2
  • 12-3-auto-deploy-20190911
  • 12-3-auto-deploy-20190916
  • 12-3-auto-deploy-20190908
  • 12-3-auto-deploy-20190901
  • 12-3-auto-deploy-20190901-32664
  • v12.10.0.pre
  • v12.9.0
  • v12.9.0-rc42
  • v12.8.7
  • v12.8.6
  • v12.8.5
  • v12.8.4
  • v12.8.3
  • v12.6.8
  • v12.7.7
  • v12.8.2
  • v12.8.1
  • v12.9.0.pre
  • v12.8.0
  • v12.8.0-rc42
  • v12.5.10
  • v12.7.6
  • v12.6.7
  • v12.7.5
  • v12.5.9
40 results

ab-routable-nplus1.yml

  • Andreas Brandl's avatar
    53801b12
    Preload routes information · 53801b12
    Andreas Brandl authored
    This fixes a high frequency N+1 issue:
    
    `RoutableActions#find_routable!` is used across many controllers to
    retrieve e.g. the Project or Namespace by path. The `#find_routable!`
    method calls `#ensure_canonical_path` which in turn retrieves
    `#full_path` from the given Routable.
    
    This in turn triggers a lookup on `routes`, leading to a high frequency
    of these queries:
    
    ```sql
    SELECT  "routes".* FROM "routes" WHERE "routes"."source_id" = $1 AND
    "routes"."source_type" = $2 LIMIT $3
    ```
    
    This is unnecessary as we already join `routes` in
    `Routable#find_by_full_path` anyways.
    Preload routes information
    Andreas Brandl authored
    This fixes a high frequency N+1 issue:
    
    `RoutableActions#find_routable!` is used across many controllers to
    retrieve e.g. the Project or Namespace by path. The `#find_routable!`
    method calls `#ensure_canonical_path` which in turn retrieves
    `#full_path` from the given Routable.
    
    This in turn triggers a lookup on `routes`, leading to a high frequency
    of these queries:
    
    ```sql
    SELECT  "routes".* FROM "routes" WHERE "routes"."source_id" = $1 AND
    "routes"."source_type" = $2 LIMIT $3
    ```
    
    This is unnecessary as we already join `routes` in
    `Routable#find_by_full_path` anyways.