Skip to content
Snippets Groups Projects
Select Git revision
  • master default protected
  • 12-9-stable
  • 12-7-stable
  • 12-6-stable
  • 12-8-stable
  • github/fork/Kloppi313/patch-1
  • 12-5-stable
  • 12-4-stable
  • github/fork/ramalokesh8477/master
  • 12-1-stable
  • 12-2-stable
  • 12-0-stable
  • 12-3-stable
  • 42-42-stable
  • github/fork/hussamgit398/patch-2
  • 12-3-auto-deploy-20190911
  • 12-3-auto-deploy-20190916
  • 12-3-auto-deploy-20190908
  • 12-3-auto-deploy-20190901
  • 12-3-auto-deploy-20190901-32664
  • v12.10.0.pre
  • v12.9.0
  • v12.9.0-rc42
  • v12.8.7
  • v12.8.6
  • v12.8.5
  • v12.8.4
  • v12.8.3
  • v12.6.8
  • v12.7.7
  • v12.8.2
  • v12.8.1
  • v12.9.0.pre
  • v12.8.0
  • v12.8.0-rc42
  • v12.5.10
  • v12.7.6
  • v12.6.7
  • v12.7.5
  • v12.5.9
40 results

project_team.rb

  • Stan Hu's avatar
    8690ca5c
    Eliminate N+1 queries in loading discussions.json endpoint · 8690ca5c
    Stan Hu authored
    In #37955,we see that the profile had a number of N+1 queries from repeated
    access to `cross_reference_not_visible_for?`. This was optimized in previous
    versions of GitLab by rendering all notes at once, counting the number of
    visible references, and then using that number to check whether a system note
    should be fully redacted.
    
    There was also another N+1 query calling `ProjectTeam#member?`, which did not
    take advantage of an optimization in prepare_notes_for_rendering that would
    preload the maximum access level per project.
    
    Closes #37955
    8690ca5c
    History
    Eliminate N+1 queries in loading discussions.json endpoint
    Stan Hu authored
    In #37955,we see that the profile had a number of N+1 queries from repeated
    access to `cross_reference_not_visible_for?`. This was optimized in previous
    versions of GitLab by rendering all notes at once, counting the number of
    visible references, and then using that number to check whether a system note
    should be fully redacted.
    
    There was also another N+1 query calling `ProjectTeam#member?`, which did not
    take advantage of an optimization in prepare_notes_for_rendering that would
    preload the maximum access level per project.
    
    Closes #37955