Skip to content
Snippets Groups Projects
Select Git revision
  • master default protected
  • 12-9-stable
  • 12-7-stable
  • 12-6-stable
  • 12-8-stable
  • github/fork/Kloppi313/patch-1
  • 12-5-stable
  • 12-4-stable
  • github/fork/ramalokesh8477/master
  • 12-1-stable
  • 12-2-stable
  • 12-0-stable
  • 12-3-stable
  • 42-42-stable
  • github/fork/hussamgit398/patch-2
  • 12-3-auto-deploy-20190911
  • 12-3-auto-deploy-20190916
  • 12-3-auto-deploy-20190908
  • 12-3-auto-deploy-20190901
  • 12-3-auto-deploy-20190901-32664
  • v12.10.0.pre
  • v12.9.0
  • v12.9.0-rc42
  • v12.8.7
  • v12.8.6
  • v12.8.5
  • v12.8.4
  • v12.8.3
  • v12.6.8
  • v12.7.7
  • v12.8.2
  • v12.8.1
  • v12.9.0.pre
  • v12.8.0
  • v12.8.0-rc42
  • v12.5.10
  • v12.7.6
  • v12.6.7
  • v12.7.5
  • v12.5.9
40 results

milestone.rb

  • Sean McGivern's avatar
    8b9b37f6
    Fix upcoming milestone for far-future due dates · 8b9b37f6
    Sean McGivern authored
    `NOW()` is a timestamp, with a maximum year (in Postgres) 294276 AD.
    
    `milestones.due_date` is a date with a maximum year (again, in Postgres)
    of 5874897 AD.
    
    If there is a due date past the limit for the timestamp, comparing the
    two will fail with:
        ERROR:  date out of range for timestamp
    
    We also need to add validations to keep the due dates sensible, but for
    now we can simply use `CURRENT_DATE` instead of `NOW()`, so the types
    match with no coercion needed.
    8b9b37f6
    History
    Fix upcoming milestone for far-future due dates
    Sean McGivern authored
    `NOW()` is a timestamp, with a maximum year (in Postgres) 294276 AD.
    
    `milestones.due_date` is a date with a maximum year (again, in Postgres)
    of 5874897 AD.
    
    If there is a due date past the limit for the timestamp, comparing the
    two will fail with:
        ERROR:  date out of range for timestamp
    
    We also need to add validations to keep the due dates sensible, but for
    now we can simply use `CURRENT_DATE` instead of `NOW()`, so the types
    match with no coercion needed.