Skip to content
Snippets Groups Projects
Select Git revision
  • master default protected
  • 12-9-stable
  • 12-7-stable
  • 12-6-stable
  • 12-8-stable
  • github/fork/Kloppi313/patch-1
  • 12-5-stable
  • 12-4-stable
  • github/fork/ramalokesh8477/master
  • 12-1-stable
  • 12-2-stable
  • 12-0-stable
  • 12-3-stable
  • 42-42-stable
  • github/fork/hussamgit398/patch-2
  • 12-3-auto-deploy-20190911
  • 12-3-auto-deploy-20190916
  • 12-3-auto-deploy-20190908
  • 12-3-auto-deploy-20190901
  • 12-3-auto-deploy-20190901-32664
  • v12.10.0.pre
  • v12.9.0
  • v12.9.0-rc42
  • v12.8.7
  • v12.8.6
  • v12.8.5
  • v12.8.4
  • v12.8.3
  • v12.6.8
  • v12.7.7
  • v12.8.2
  • v12.8.1
  • v12.9.0.pre
  • v12.8.0
  • v12.8.0-rc42
  • v12.5.10
  • v12.7.6
  • v12.6.7
  • v12.7.5
  • v12.5.9
40 results

close_service_spec.rb

  • Pierre de La Morinerie's avatar
    466b768b
    Send notification emails to the "project", and put people in Cc · 466b768b
    Pierre de La Morinerie authored
    This fixes email threading in Mail.app, that doesn't like when a thread
    doesn't have stable recipients.
    
    For instance, here is a possible sender-recipient combinations before:
    
    From: A
    To: Me
    New issue
    
    From: B
    To: Me
    Reply on new issue
    
    From: A
    To: Me
    Another reply
    
    Mail.app doesn't see B as a participant to the original email thread,
    and decides to break the thread: it will group all messages from A
    together, and separately all messages from B.
    
    This commit makes the thread look like this:
    
    From: A
    To: gitlab/project
    Cc: Me
    New issue
    
    From: B
    To: gitlab/project
    Cc: Me
    Reply on new issue
    
    From: A
    To: gitlab/project
    Cc: Me
    Another reply
    
    Mail.app sees a common recipient, and group the thread correctly.
    466b768b
    History
    Send notification emails to the "project", and put people in Cc
    Pierre de La Morinerie authored
    This fixes email threading in Mail.app, that doesn't like when a thread
    doesn't have stable recipients.
    
    For instance, here is a possible sender-recipient combinations before:
    
    From: A
    To: Me
    New issue
    
    From: B
    To: Me
    Reply on new issue
    
    From: A
    To: Me
    Another reply
    
    Mail.app doesn't see B as a participant to the original email thread,
    and decides to break the thread: it will group all messages from A
    together, and separately all messages from B.
    
    This commit makes the thread look like this:
    
    From: A
    To: gitlab/project
    Cc: Me
    New issue
    
    From: B
    To: gitlab/project
    Cc: Me
    Reply on new issue
    
    From: A
    To: gitlab/project
    Cc: Me
    Another reply
    
    Mail.app sees a common recipient, and group the thread correctly.