Skip to content
Snippets Groups Projects
Select Git revision
  • master default protected
  • 12-9-stable
  • 12-7-stable
  • 12-6-stable
  • 12-8-stable
  • github/fork/Kloppi313/patch-1
  • 12-5-stable
  • 12-4-stable
  • github/fork/ramalokesh8477/master
  • 12-1-stable
  • 12-2-stable
  • 12-0-stable
  • 12-3-stable
  • 42-42-stable
  • github/fork/hussamgit398/patch-2
  • 12-3-auto-deploy-20190911
  • 12-3-auto-deploy-20190916
  • 12-3-auto-deploy-20190908
  • 12-3-auto-deploy-20190901
  • 12-3-auto-deploy-20190901-32664
  • v12.10.0.pre
  • v12.9.0
  • v12.9.0-rc42
  • v12.8.7
  • v12.8.6
  • v12.8.5
  • v12.8.4
  • v12.8.3
  • v12.6.8
  • v12.7.7
  • v12.8.2
  • v12.8.1
  • v12.9.0.pre
  • v12.8.0
  • v12.8.0-rc42
  • v12.5.10
  • v12.7.6
  • v12.6.7
  • v12.7.5
  • v12.5.9
40 results

event.rb

  • Yorick Peterse's avatar
    9a3e4b8d
    Remove redundant WHERE from event queries · 9a3e4b8d
    Yorick Peterse authored
    The default scope in Event would add a "WHERE author_id IS NOT NULL"
    clause to every query. Now that "events.author_id" has a NOT NULL clause
    set this filter is redundant and we can safely remove it.
    
    In this commit we also add a validation on events.author_id (previously
    only defined in PushEvent) just in case something tries to create data
    without an author ID. This way we can present a nicer error message
    compared to PostgreSQL's foreign key error messages.
    
    Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/38129
    Verified
    9a3e4b8d
    History
    Remove redundant WHERE from event queries
    Yorick Peterse authored
    The default scope in Event would add a "WHERE author_id IS NOT NULL"
    clause to every query. Now that "events.author_id" has a NOT NULL clause
    set this filter is redundant and we can safely remove it.
    
    In this commit we also add a validation on events.author_id (previously
    only defined in PushEvent) just in case something tries to create data
    without an author ID. This way we can present a nicer error message
    compared to PostgreSQL's foreign key error messages.
    
    Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/38129