Skip to content
Snippets Groups Projects
Select Git revision
  • master default protected
  • 12-9-stable
  • 12-7-stable
  • 12-6-stable
  • 12-8-stable
  • github/fork/Kloppi313/patch-1
  • 12-5-stable
  • 12-4-stable
  • github/fork/ramalokesh8477/master
  • 12-1-stable
  • 12-2-stable
  • 12-0-stable
  • 12-3-stable
  • 42-42-stable
  • github/fork/hussamgit398/patch-2
  • 12-3-auto-deploy-20190911
  • 12-3-auto-deploy-20190916
  • 12-3-auto-deploy-20190908
  • 12-3-auto-deploy-20190901
  • 12-3-auto-deploy-20190901-32664
  • v12.10.0.pre
  • v12.9.0
  • v12.9.0-rc42
  • v12.8.7
  • v12.8.6
  • v12.8.5
  • v12.8.4
  • v12.8.3
  • v12.6.8
  • v12.7.7
  • v12.8.2
  • v12.8.1
  • v12.9.0.pre
  • v12.8.0
  • v12.8.0-rc42
  • v12.5.10
  • v12.7.6
  • v12.6.7
  • v12.7.5
  • v12.5.9
40 results

namespace.rb

  • Yorick Peterse's avatar
    ac702af8
    Fix setting share_with_group_lock · ac702af8
    Yorick Peterse authored
    Prior to this commit running
    Namespace#force_share_with_group_lock_on_descendants would result in
    updating _all_ namespaces in the namespaces table, not just the
    descendants. This is the result of ActiveRecord::Relation#update_all not
    taking into account the CTE. To work around this we use the CTE query as
    a sub-query instead of directly calling #update_all.
    
    To prevent this from happening the relations returned by
    Gitlab::GroupHierarchy are now marked as read-only, resulting in an
    error being raised when methods such as #update_all are used.
    
    Fortunately on GitLab.com our statement timeouts appear to have
    prevented this query from actually doing any damage other than causing
    a very large amount of dead tuples.
    
    Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/37916
    Verified
    ac702af8
    History
    Fix setting share_with_group_lock
    Yorick Peterse authored
    Prior to this commit running
    Namespace#force_share_with_group_lock_on_descendants would result in
    updating _all_ namespaces in the namespaces table, not just the
    descendants. This is the result of ActiveRecord::Relation#update_all not
    taking into account the CTE. To work around this we use the CTE query as
    a sub-query instead of directly calling #update_all.
    
    To prevent this from happening the relations returned by
    Gitlab::GroupHierarchy are now marked as read-only, resulting in an
    error being raised when methods such as #update_all are used.
    
    Fortunately on GitLab.com our statement timeouts appear to have
    prevented this query from actually doing any damage other than causing
    a very large amount of dead tuples.
    
    Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/37916