Skip to content
Snippets Groups Projects
Select Git revision
  • master default protected
  • 12-9-stable
  • 12-7-stable
  • 12-6-stable
  • 12-8-stable
  • github/fork/Kloppi313/patch-1
  • 12-5-stable
  • 12-4-stable
  • github/fork/ramalokesh8477/master
  • 12-1-stable
  • 12-2-stable
  • 12-0-stable
  • 12-3-stable
  • 42-42-stable
  • github/fork/hussamgit398/patch-2
  • 12-3-auto-deploy-20190911
  • 12-3-auto-deploy-20190916
  • 12-3-auto-deploy-20190908
  • 12-3-auto-deploy-20190901
  • 12-3-auto-deploy-20190901-32664
  • v12.10.0.pre
  • v12.9.0
  • v12.9.0-rc42
  • v12.8.7
  • v12.8.6
  • v12.8.5
  • v12.8.4
  • v12.8.3
  • v12.6.8
  • v12.7.7
  • v12.8.2
  • v12.8.1
  • v12.9.0.pre
  • v12.8.0
  • v12.8.0-rc42
  • v12.5.10
  • v12.7.6
  • v12.6.7
  • v12.7.5
  • v12.5.9
40 results

merge_request.rb

  • Nick Thomas's avatar
    b02f9b61
    Look at notes created just before merge when deciding if an MR can be reverted · b02f9b61
    Nick Thomas authored
    On MySQL, at least, `Note#created_at` doesn't seem to store fractional seconds,
    while `MergeRequest::Metrics#merged_at` does. This breaks the optimization
    assumption that we only need to search for notes created *after* the MR has
    been merged.
    
    Unsynchronized system clocks also make this a dangerous assumption to make.
    
    Adding a minute of leeway still optimizes away most notes, but allows both
    cases to be handled more gracefully. If the system clocks are more than a
    minute out, we'll still be broken, of course.
    Verified
    b02f9b61
    History
    Look at notes created just before merge when deciding if an MR can be reverted
    Nick Thomas authored
    On MySQL, at least, `Note#created_at` doesn't seem to store fractional seconds,
    while `MergeRequest::Metrics#merged_at` does. This breaks the optimization
    assumption that we only need to search for notes created *after* the MR has
    been merged.
    
    Unsynchronized system clocks also make this a dangerous assumption to make.
    
    Adding a minute of leeway still optimizes away most notes, but allows both
    cases to be handled more gracefully. If the system clocks are more than a
    minute out, we'll still be broken, of course.