Skip to content
Snippets Groups Projects
Select Git revision
  • master default protected
  • 12-9-stable
  • 12-7-stable
  • 12-6-stable
  • 12-8-stable
  • github/fork/Kloppi313/patch-1
  • 12-5-stable
  • 12-4-stable
  • github/fork/ramalokesh8477/master
  • 12-1-stable
  • 12-2-stable
  • 12-0-stable
  • 12-3-stable
  • 42-42-stable
  • github/fork/hussamgit398/patch-2
  • 12-3-auto-deploy-20190911
  • 12-3-auto-deploy-20190916
  • 12-3-auto-deploy-20190908
  • 12-3-auto-deploy-20190901
  • 12-3-auto-deploy-20190901-32664
  • v12.10.0.pre
  • v12.9.0
  • v12.9.0-rc42
  • v12.8.7
  • v12.8.6
  • v12.8.5
  • v12.8.4
  • v12.8.3
  • v12.6.8
  • v12.7.7
  • v12.8.2
  • v12.8.1
  • v12.9.0.pre
  • v12.8.0
  • v12.8.0-rc42
  • v12.5.10
  • v12.7.6
  • v12.6.7
  • v12.7.5
  • v12.5.9
40 results

sidekiq_queues.yml

  • Yorick Peterse's avatar
    b3566a01
    Stop using Sidekiq for updating Key#last_used_at · b3566a01
    Yorick Peterse authored
    This makes things simpler as no scheduling is involved. Further we
    remove the need for running a SELECT + UPDATE just to get the key and
    update it, whereas we only need an UPDATE when setting last_used_at
    directly in a request.
    
    The added service class takes care of updating Key#last_used_at without
    using Sidekiq. Further it makes sure we only try to obtain a Redis lease
    if we're confident that we actually need to do so, instead of always
    obtaining it. We also make sure to _only_ update last_used_at instead of
    also updating updated_at.
    
    Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/36663
    Verified
    b3566a01
    History
    Stop using Sidekiq for updating Key#last_used_at
    Yorick Peterse authored
    This makes things simpler as no scheduling is involved. Further we
    remove the need for running a SELECT + UPDATE just to get the key and
    update it, whereas we only need an UPDATE when setting last_used_at
    directly in a request.
    
    The added service class takes care of updating Key#last_used_at without
    using Sidekiq. Further it makes sure we only try to obtain a Redis lease
    if we're confident that we actually need to do so, instead of always
    obtaining it. We also make sure to _only_ update last_used_at instead of
    also updating updated_at.
    
    Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/36663