Skip to content
Snippets Groups Projects
Select Git revision
  • master default protected
  • 12-9-stable
  • 12-7-stable
  • 12-6-stable
  • 12-8-stable
  • github/fork/Kloppi313/patch-1
  • 12-5-stable
  • 12-4-stable
  • github/fork/ramalokesh8477/master
  • 12-1-stable
  • 12-2-stable
  • 12-0-stable
  • 12-3-stable
  • 42-42-stable
  • github/fork/hussamgit398/patch-2
  • 12-3-auto-deploy-20190911
  • 12-3-auto-deploy-20190916
  • 12-3-auto-deploy-20190908
  • 12-3-auto-deploy-20190901
  • 12-3-auto-deploy-20190901-32664
  • v12.10.0.pre
  • v12.9.0
  • v12.9.0-rc42
  • v12.8.7
  • v12.8.6
  • v12.8.5
  • v12.8.4
  • v12.8.3
  • v12.6.8
  • v12.7.7
  • v12.8.2
  • v12.8.1
  • v12.9.0.pre
  • v12.8.0
  • v12.8.0-rc42
  • v12.5.10
  • v12.7.6
  • v12.6.7
  • v12.7.5
  • v12.5.9
40 results

cycle_analytics.rb

  • Timothy Andrew's avatar
    ba25e2f1
    Improve performance of the cycle analytics page. · ba25e2f1
    Timothy Andrew authored
    1. These changes bring down page load time for 100 issues from more than
       a minute to about 1.5 seconds.
    
    2. This entire commit is composed of these types of performance
       enhancements:
    
         - Cache relevant data in `IssueMetrics` wherever possible.
         - Cache relevant data in `MergeRequestMetrics` wherever possible.
         - Preload metrics
    
    3. Given these improvements, we now only need to make 4 SQL calls:
    
        - Load all issues
        - Load all merge requests
        - Load all metrics for the issues
        - Load all metrics for the merge requests
    
    4. A list of all the data points that are now being pre-calculated:
    
        a. The first time an issue is mentioned in a commit
    
          - In `GitPushService`, find all issues mentioned by the given commit
            using `ReferenceExtractor`. Set the `first_mentioned_in_commit_at`
            flag for each of them.
    
          - There seems to be a (pre-existing) bug here - files (and
            therefore commits) created using the Web CI don't have
            cross-references created, and issues are not closed even when
            the commit title is "Fixes #xx".
    
        b. The first time a merge request is deployed to production
    
          When a `Deployment` is created, find all merge requests that
          were merged in before the deployment, and set the
          `first_deployed_to_production_at` flag for each of them.
    
        c. The start / end time for a merge request pipeline
    
          Hook into the `Pipeline` state machine. When the `status` moves to
          `running`, find the merge requests whose tip commit matches the
          pipeline, and record the `latest_build_started_at` time for each
          of them. When the `status` moves to `success`, record the
          `latest_build_finished_at` time.
    
        d. The merge requests that close an issue
    
          - This was a big cause of the performance problems we were having
            with Cycle Analytics. We need to use `ReferenceExtractor` to make
            this calculation, which is slow when we have to run it on a large
            number of merge requests.
    
          - When a merge request is created, updated, or refreshed, find the
            issues it closes, and create an instance of
            `MergeRequestsClosingIssues`, which acts as a join model between
            merge requests and issues.
    
          - If a `MergeRequestsClosingIssues` instance links a merge request
            and an issue, that issue closes that merge request.
    
    5. The `Queries` module was changed into a class, so we can cache the
       results of `issues` and `merge_requests_closing_issues` across
       various cycle analytics stages.
    
    6. The code added in this commit is untested. Tests will be added in the
       next commit.
    ba25e2f1
    History
    Improve performance of the cycle analytics page.
    Timothy Andrew authored
    1. These changes bring down page load time for 100 issues from more than
       a minute to about 1.5 seconds.
    
    2. This entire commit is composed of these types of performance
       enhancements:
    
         - Cache relevant data in `IssueMetrics` wherever possible.
         - Cache relevant data in `MergeRequestMetrics` wherever possible.
         - Preload metrics
    
    3. Given these improvements, we now only need to make 4 SQL calls:
    
        - Load all issues
        - Load all merge requests
        - Load all metrics for the issues
        - Load all metrics for the merge requests
    
    4. A list of all the data points that are now being pre-calculated:
    
        a. The first time an issue is mentioned in a commit
    
          - In `GitPushService`, find all issues mentioned by the given commit
            using `ReferenceExtractor`. Set the `first_mentioned_in_commit_at`
            flag for each of them.
    
          - There seems to be a (pre-existing) bug here - files (and
            therefore commits) created using the Web CI don't have
            cross-references created, and issues are not closed even when
            the commit title is "Fixes #xx".
    
        b. The first time a merge request is deployed to production
    
          When a `Deployment` is created, find all merge requests that
          were merged in before the deployment, and set the
          `first_deployed_to_production_at` flag for each of them.
    
        c. The start / end time for a merge request pipeline
    
          Hook into the `Pipeline` state machine. When the `status` moves to
          `running`, find the merge requests whose tip commit matches the
          pipeline, and record the `latest_build_started_at` time for each
          of them. When the `status` moves to `success`, record the
          `latest_build_finished_at` time.
    
        d. The merge requests that close an issue
    
          - This was a big cause of the performance problems we were having
            with Cycle Analytics. We need to use `ReferenceExtractor` to make
            this calculation, which is slow when we have to run it on a large
            number of merge requests.
    
          - When a merge request is created, updated, or refreshed, find the
            issues it closes, and create an instance of
            `MergeRequestsClosingIssues`, which acts as a join model between
            merge requests and issues.
    
          - If a `MergeRequestsClosingIssues` instance links a merge request
            and an issue, that issue closes that merge request.
    
    5. The `Queries` module was changed into a class, so we can cache the
       results of `issues` and `merge_requests_closing_issues` across
       various cycle analytics stages.
    
    6. The code added in this commit is untested. Tests will be added in the
       next commit.