Skip to content
Snippets Groups Projects
Select Git revision
  • master default protected
  • 12-9-stable
  • 12-7-stable
  • 12-6-stable
  • 12-8-stable
  • github/fork/Kloppi313/patch-1
  • 12-5-stable
  • 12-4-stable
  • github/fork/ramalokesh8477/master
  • 12-1-stable
  • 12-2-stable
  • 12-0-stable
  • 12-3-stable
  • 42-42-stable
  • github/fork/hussamgit398/patch-2
  • 12-3-auto-deploy-20190911
  • 12-3-auto-deploy-20190916
  • 12-3-auto-deploy-20190908
  • 12-3-auto-deploy-20190901
  • 12-3-auto-deploy-20190901-32664
  • v12.10.0.pre
  • v12.9.0
  • v12.9.0-rc42
  • v12.8.7
  • v12.8.6
  • v12.8.5
  • v12.8.4
  • v12.8.3
  • v12.6.8
  • v12.7.7
  • v12.8.2
  • v12.8.1
  • v12.9.0.pre
  • v12.8.0
  • v12.8.0-rc42
  • v12.5.10
  • v12.7.6
  • v12.6.7
  • v12.7.5
  • v12.5.9
40 results

merge_request.rb

  • Sean McGivern's avatar
    ba9b4c4d
    Avoid hitting statement timeout finding MR pipelines · ba9b4c4d
    Sean McGivern authored
    For MRs with many thousands of commits, `SELECT DISTINCT(sha)` will be very
    slow.
    
    What we can't do to fix this:
    
    1. Add an index. Postgres won't use it for DISTINCT without a lot of ceremony.
    2. Do the `uniq` in Ruby. That can still be very slow with hundreds of
       thousands of commits.
    3. Use a subquery. We haven't removed the `st_commits` column yet, but we will
       soon.
    
    Until 3 is available to us, we can just do 2, but also add a limit clause. There
    is no ordering, so this may return different results, but our goal with these
    MRs is just to get them to load, so it's not a huge deal.
    ba9b4c4d
    History
    Avoid hitting statement timeout finding MR pipelines
    Sean McGivern authored
    For MRs with many thousands of commits, `SELECT DISTINCT(sha)` will be very
    slow.
    
    What we can't do to fix this:
    
    1. Add an index. Postgres won't use it for DISTINCT without a lot of ceremony.
    2. Do the `uniq` in Ruby. That can still be very slow with hundreds of
       thousands of commits.
    3. Use a subquery. We haven't removed the `st_commits` column yet, but we will
       soon.
    
    Until 3 is available to us, we can just do 2, but also add a limit clause. There
    is no ordering, so this may return different results, but our goal with these
    MRs is just to get them to load, so it's not a huge deal.