Skip to content
Snippets Groups Projects
Select Git revision
  • master default protected
  • 12-9-stable
  • 12-7-stable
  • 12-6-stable
  • 12-8-stable
  • github/fork/Kloppi313/patch-1
  • 12-5-stable
  • 12-4-stable
  • github/fork/ramalokesh8477/master
  • 12-1-stable
  • 12-2-stable
  • 12-0-stable
  • 12-3-stable
  • 42-42-stable
  • github/fork/hussamgit398/patch-2
  • 12-3-auto-deploy-20190911
  • 12-3-auto-deploy-20190916
  • 12-3-auto-deploy-20190908
  • 12-3-auto-deploy-20190901
  • 12-3-auto-deploy-20190901-32664
  • v12.10.0.pre
  • v12.9.0
  • v12.9.0-rc42
  • v12.8.7
  • v12.8.6
  • v12.8.5
  • v12.8.4
  • v12.8.3
  • v12.6.8
  • v12.7.7
  • v12.8.2
  • v12.8.1
  • v12.9.0.pre
  • v12.8.0
  • v12.8.0-rc42
  • v12.5.10
  • v12.7.6
  • v12.6.7
  • v12.7.5
  • v12.5.9
40 results

instrumentation.md

  • Yorick Peterse's avatar
    be3b8784
    Track method call times/counts as a single metric · be3b8784
    Yorick Peterse authored
    Previously we'd create a separate Metric instance for every method call
    that would exceed the method call threshold. This is problematic because
    it doesn't provide us with information to accurately get the _total_
    execution time of a particular method. For example, if the method
    "Foo#bar" was called 4 times with a runtime of ~10 milliseconds we'd end
    up with 4 different Metric instances. If we were to then get the
    average/95th percentile/etc of the timings this would be roughly 10
    milliseconds. However, the _actual_ total time spent in this method
    would be around 40 milliseconds.
    
    To solve this problem we now create a single Metric instance per method.
    This Metric instance contains the _total_ real/CPU time and the call
    count for every instrumented method.
    be3b8784
    History
    Track method call times/counts as a single metric
    Yorick Peterse authored
    Previously we'd create a separate Metric instance for every method call
    that would exceed the method call threshold. This is problematic because
    it doesn't provide us with information to accurately get the _total_
    execution time of a particular method. For example, if the method
    "Foo#bar" was called 4 times with a runtime of ~10 milliseconds we'd end
    up with 4 different Metric instances. If we were to then get the
    average/95th percentile/etc of the timings this would be roughly 10
    milliseconds. However, the _actual_ total time spent in this method
    would be around 40 milliseconds.
    
    To solve this problem we now create a single Metric instance per method.
    This Metric instance contains the _total_ real/CPU time and the call
    count for every instrumented method.