Skip to content
Snippets Groups Projects
Select Git revision
  • master default protected
  • 12-9-stable
  • 12-7-stable
  • 12-6-stable
  • 12-8-stable
  • github/fork/Kloppi313/patch-1
  • 12-5-stable
  • 12-4-stable
  • github/fork/ramalokesh8477/master
  • 12-1-stable
  • 12-2-stable
  • 12-0-stable
  • 12-3-stable
  • 42-42-stable
  • github/fork/hussamgit398/patch-2
  • 12-3-auto-deploy-20190911
  • 12-3-auto-deploy-20190916
  • 12-3-auto-deploy-20190908
  • 12-3-auto-deploy-20190901
  • 12-3-auto-deploy-20190901-32664
  • v12.10.0.pre
  • v12.9.0
  • v12.9.0-rc42
  • v12.8.7
  • v12.8.6
  • v12.8.5
  • v12.8.4
  • v12.8.3
  • v12.6.8
  • v12.7.7
  • v12.8.2
  • v12.8.1
  • v12.9.0.pre
  • v12.8.0
  • v12.8.0-rc42
  • v12.5.10
  • v12.7.6
  • v12.6.7
  • v12.7.5
  • v12.5.9
40 results

issues_controller.rb

  • Sean McGivern's avatar
    c2fc4066
    Refactor IssuableFinder to extract model-specific logic · c2fc4066
    Sean McGivern authored
    By extracting a new `filter_items` method, we can override that in the
    IssuesFinder and MergeRequestsFinder separately, so we don't need checks that
    the model is the correct one, because we can just use the class we're in to know
    that.
    
    We can do the same for the VALID_PARAMS constant, by making it a class method.
    c2fc4066
    History
    Refactor IssuableFinder to extract model-specific logic
    Sean McGivern authored
    By extracting a new `filter_items` method, we can override that in the
    IssuesFinder and MergeRequestsFinder separately, so we don't need checks that
    the model is the correct one, because we can just use the class we're in to know
    that.
    
    We can do the same for the VALID_PARAMS constant, by making it a class method.