Skip to content
Snippets Groups Projects
Select Git revision
  • master default protected
  • 12-9-stable
  • 12-7-stable
  • 12-6-stable
  • 12-8-stable
  • github/fork/Kloppi313/patch-1
  • 12-5-stable
  • 12-4-stable
  • github/fork/ramalokesh8477/master
  • 12-1-stable
  • 12-2-stable
  • 12-0-stable
  • 12-3-stable
  • 42-42-stable
  • github/fork/hussamgit398/patch-2
  • 12-3-auto-deploy-20190911
  • 12-3-auto-deploy-20190916
  • 12-3-auto-deploy-20190908
  • 12-3-auto-deploy-20190901
  • 12-3-auto-deploy-20190901-32664
  • v12.10.0.pre
  • v12.9.0
  • v12.9.0-rc42
  • v12.8.7
  • v12.8.6
  • v12.8.5
  • v12.8.4
  • v12.8.3
  • v12.6.8
  • v12.7.7
  • v12.8.2
  • v12.8.1
  • v12.9.0.pre
  • v12.8.0
  • v12.8.0-rc42
  • v12.5.10
  • v12.7.6
  • v12.6.7
  • v12.7.5
  • v12.5.9
40 results

security-60143-address-xss-issue-in-wiki-links.yml

  • Kerri Miller's avatar
    f383ad62
    Reject slug+uri concat if slug is deemed unsafe · f383ad62
    Kerri Miller authored
    First reported:
      https://gitlab.com/gitlab-org/gitlab-ce/issues/60143
    
    When the page slug is "javascript:" and we attempt to link to a relative
    path (using `.` or `..`) the code will concatenate the slug and the uri.
    This MR adds a guard to that concat step that will return `nil` if the
    incoming slug matches against any of the "unsafe" slug regexes;
    currently this is only for the slug "javascript:" but can be extended if
    needed. Manually tested against a non-exhaustive list from OWASP of
    common javascript XSS exploits that have to to with mangling the
    "javascript:" method, and all are caught by this change or by existing
    code that ingests the user-specified slug.
    f383ad62
    History
    Reject slug+uri concat if slug is deemed unsafe
    Kerri Miller authored
    First reported:
      https://gitlab.com/gitlab-org/gitlab-ce/issues/60143
    
    When the page slug is "javascript:" and we attempt to link to a relative
    path (using `.` or `..`) the code will concatenate the slug and the uri.
    This MR adds a guard to that concat step that will return `nil` if the
    incoming slug matches against any of the "unsafe" slug regexes;
    currently this is only for the slug "javascript:" but can be extended if
    needed. Manually tested against a non-exhaustive list from OWASP of
    common javascript XSS exploits that have to to with mangling the
    "javascript:" method, and all are caught by this change or by existing
    code that ingests the user-specified slug.