Skip to content
Snippets Groups Projects
Select Git revision
  • master default protected
  • 12-9-stable
  • 12-7-stable
  • 12-6-stable
  • 12-8-stable
  • github/fork/Kloppi313/patch-1
  • 12-5-stable
  • 12-4-stable
  • github/fork/ramalokesh8477/master
  • 12-1-stable
  • 12-2-stable
  • 12-0-stable
  • 12-3-stable
  • 42-42-stable
  • github/fork/hussamgit398/patch-2
  • 12-3-auto-deploy-20190911
  • 12-3-auto-deploy-20190916
  • 12-3-auto-deploy-20190908
  • 12-3-auto-deploy-20190901
  • 12-3-auto-deploy-20190901-32664
  • v12.10.0.pre
  • v12.9.0
  • v12.9.0-rc42
  • v12.8.7
  • v12.8.6
  • v12.8.5
  • v12.8.4
  • v12.8.3
  • v12.6.8
  • v12.7.7
  • v12.8.2
  • v12.8.1
  • v12.9.0.pre
  • v12.8.0
  • v12.8.0-rc42
  • v12.5.10
  • v12.7.6
  • v12.6.7
  • v12.7.5
  • v12.5.9
40 results

event.rb

  • Yorick Peterse's avatar
    c9bcfc63
    Remove lease from Event#reset_project_activity · c9bcfc63
    Yorick Peterse authored
    Per GitLab.com's performance metrics this method could take up to 5
    seconds of wall time to complete, while only taking 1-2 milliseconds of
    CPU time. Removing the Redis lease in favour of conditional updates
    allows us to work around this.
    
    A slight drawback is that this allows for multiple threads/processes to
    try and update the same row. However, only a single thread/process will
    ever win since the UPDATE query uses a WHERE condition to only update
    rows that were not updated in the last hour.
    
    Fixes gitlab-org/gitlab-ce#22473
    Remove lease from Event#reset_project_activity
    Yorick Peterse authored
    Per GitLab.com's performance metrics this method could take up to 5
    seconds of wall time to complete, while only taking 1-2 milliseconds of
    CPU time. Removing the Redis lease in favour of conditional updates
    allows us to work around this.
    
    A slight drawback is that this allows for multiple threads/processes to
    try and update the same row. However, only a single thread/process will
    ever win since the UPDATE query uses a WHERE condition to only update
    rows that were not updated in the last hour.
    
    Fixes gitlab-org/gitlab-ce#22473