Skip to content
Snippets Groups Projects
Select Git revision
  • master default protected
  • 12-9-stable
  • 12-7-stable
  • 12-6-stable
  • 12-8-stable
  • github/fork/Kloppi313/patch-1
  • 12-5-stable
  • 12-4-stable
  • github/fork/ramalokesh8477/master
  • 12-1-stable
  • 12-2-stable
  • 12-0-stable
  • 12-3-stable
  • 42-42-stable
  • github/fork/hussamgit398/patch-2
  • 12-3-auto-deploy-20190911
  • 12-3-auto-deploy-20190916
  • 12-3-auto-deploy-20190908
  • 12-3-auto-deploy-20190901
  • 12-3-auto-deploy-20190901-32664
  • v12.10.0.pre
  • v12.9.0
  • v12.9.0-rc42
  • v12.8.7
  • v12.8.6
  • v12.8.5
  • v12.8.4
  • v12.8.3
  • v12.6.8
  • v12.7.7
  • v12.8.2
  • v12.8.1
  • v12.9.0.pre
  • v12.8.0
  • v12.8.0-rc42
  • v12.5.10
  • v12.7.6
  • v12.6.7
  • v12.7.5
  • v12.5.9
40 results

create_service.rb

  • Timothy Andrew's avatar
    cebcc417
    Implement final review comments from @rymai. · cebcc417
    Timothy Andrew authored
    1. Instantiate `ProtectedBranchesAccessSelect` from `dispatcher`
    
    2. Use `can?(user, ...)` instead of `user.can?(...)`
    
    3. Add `DOWNTIME` notes to all migrations added in !5081.
    
    4. Add an explicit `down` method for migrations removing the
       `developers_can_push` and `developers_can_merge` columns, ensuring that
       the columns created (on rollback) have the appropriate defaults.
    
    5. Remove duplicate CHANGELOG entries.
    
    6. Blank lines after guard clauses.
    cebcc417
    History
    Implement final review comments from @rymai.
    Timothy Andrew authored
    1. Instantiate `ProtectedBranchesAccessSelect` from `dispatcher`
    
    2. Use `can?(user, ...)` instead of `user.can?(...)`
    
    3. Add `DOWNTIME` notes to all migrations added in !5081.
    
    4. Add an explicit `down` method for migrations removing the
       `developers_can_push` and `developers_can_merge` columns, ensuring that
       the columns created (on rollback) have the appropriate defaults.
    
    5. Remove duplicate CHANGELOG entries.
    
    6. Blank lines after guard clauses.