Skip to content
Snippets Groups Projects
Select Git revision
  • master default protected
  • 12-9-stable
  • 12-7-stable
  • 12-6-stable
  • 12-8-stable
  • github/fork/Kloppi313/patch-1
  • 12-5-stable
  • 12-4-stable
  • github/fork/ramalokesh8477/master
  • 12-1-stable
  • 12-2-stable
  • 12-0-stable
  • 12-3-stable
  • 42-42-stable
  • github/fork/hussamgit398/patch-2
  • 12-3-auto-deploy-20190911
  • 12-3-auto-deploy-20190916
  • 12-3-auto-deploy-20190908
  • 12-3-auto-deploy-20190901
  • 12-3-auto-deploy-20190901-32664
  • v12.10.0.pre
  • v12.9.0
  • v12.9.0-rc42
  • v12.8.7
  • v12.8.6
  • v12.8.5
  • v12.8.4
  • v12.8.3
  • v12.6.8
  • v12.7.7
  • v12.8.2
  • v12.8.1
  • v12.9.0.pre
  • v12.8.0
  • v12.8.0-rc42
  • v12.5.10
  • v12.7.6
  • v12.6.7
  • v12.7.5
  • v12.5.9
40 results

projects_finder.rb

  • Yorick Peterse's avatar
    d2934722
    Refactor ProjectsFinder#init_collection · d2934722
    Yorick Peterse authored
    This changes ProjectsFinder#init_collection so it no longer relies on a
    UNION. For example, to get starred projects of a user we used to run:
    
        SELECT projects.*
        FROM projects
        WHERE projects.pending_delete = 'f'
        AND (
            projects.id IN (
                SELECT projects.id
                FROM projects
                INNER JOIN users_star_projects
                    ON users_star_projects.project_id = projects.id
                INNER JOIN project_authorizations
                    ON projects.id = project_authorizations.project_id
                WHERE projects.pending_delete = 'f'
                AND project_authorizations.user_id = 1
                AND users_star_projects.user_id = 1
    
                UNION
    
                SELECT projects.id
                FROM projects
                INNER JOIN users_star_projects
                    ON users_star_projects.project_id = projects.id
                WHERE projects.visibility_level IN (20, 10)
                AND users_star_projects.user_id = 1
            )
        )
        ORDER BY projects.id DESC;
    
    With these changes the above query is turned into the following instead:
    
        SELECT projects.*
        FROM projects
        INNER JOIN users_star_projects
            ON users_star_projects.project_id = projects.id
        WHERE projects.pending_delete = 'f'
        AND (
            EXISTS (
                SELECT 1
                FROM project_authorizations
                WHERE project_authorizations.user_id = 1
                AND (project_id = projects.id)
            )
            OR projects.visibility_level IN (20,10)
        )
        AND users_star_projects.user_id = 1
        ORDER BY projects.id DESC;
    
    This query in turn produces a better execution plan and takes less time,
    though the difference is only a few milliseconds (this however depends
    on the amount of data involved and additional conditions that may be
    added).
    Verified
    d2934722
    History
    Refactor ProjectsFinder#init_collection
    Yorick Peterse authored
    This changes ProjectsFinder#init_collection so it no longer relies on a
    UNION. For example, to get starred projects of a user we used to run:
    
        SELECT projects.*
        FROM projects
        WHERE projects.pending_delete = 'f'
        AND (
            projects.id IN (
                SELECT projects.id
                FROM projects
                INNER JOIN users_star_projects
                    ON users_star_projects.project_id = projects.id
                INNER JOIN project_authorizations
                    ON projects.id = project_authorizations.project_id
                WHERE projects.pending_delete = 'f'
                AND project_authorizations.user_id = 1
                AND users_star_projects.user_id = 1
    
                UNION
    
                SELECT projects.id
                FROM projects
                INNER JOIN users_star_projects
                    ON users_star_projects.project_id = projects.id
                WHERE projects.visibility_level IN (20, 10)
                AND users_star_projects.user_id = 1
            )
        )
        ORDER BY projects.id DESC;
    
    With these changes the above query is turned into the following instead:
    
        SELECT projects.*
        FROM projects
        INNER JOIN users_star_projects
            ON users_star_projects.project_id = projects.id
        WHERE projects.pending_delete = 'f'
        AND (
            EXISTS (
                SELECT 1
                FROM project_authorizations
                WHERE project_authorizations.user_id = 1
                AND (project_id = projects.id)
            )
            OR projects.visibility_level IN (20,10)
        )
        AND users_star_projects.user_id = 1
        ORDER BY projects.id DESC;
    
    This query in turn produces a better execution plan and takes less time,
    though the difference is only a few milliseconds (this however depends
    on the amount of data involved and additional conditions that may be
    added).