Skip to content
Snippets Groups Projects
Select Git revision
  • master default protected
  • 12-9-stable
  • 12-7-stable
  • 12-6-stable
  • 12-8-stable
  • github/fork/Kloppi313/patch-1
  • 12-5-stable
  • 12-4-stable
  • github/fork/ramalokesh8477/master
  • 12-1-stable
  • 12-2-stable
  • 12-0-stable
  • 12-3-stable
  • 42-42-stable
  • github/fork/hussamgit398/patch-2
  • 12-3-auto-deploy-20190911
  • 12-3-auto-deploy-20190916
  • 12-3-auto-deploy-20190908
  • 12-3-auto-deploy-20190901
  • 12-3-auto-deploy-20190901-32664
  • v12.10.0.pre
  • v12.9.0
  • v12.9.0-rc42
  • v12.8.7
  • v12.8.6
  • v12.8.5
  • v12.8.4
  • v12.8.3
  • v12.6.8
  • v12.7.7
  • v12.8.2
  • v12.8.1
  • v12.9.0.pre
  • v12.8.0
  • v12.8.0-rc42
  • v12.5.10
  • v12.7.6
  • v12.6.7
  • v12.7.5
  • v12.5.9
40 results

project_team.rb

  • Sean McGivern's avatar
    db9979bc
    Fix project member access for group links · db9979bc
    Sean McGivern authored
    `ProjectTeam#find_member` doesn't take group links into account. It was
    used in two places:
    
    1. An admin view - it can stay here.
    2. `ProjectTeam#member?`, which is often used to decide if a user has
       access to view something.
    
    This second part broke confidential issues viewing. `IssuesFinder` ends
    up delegating to `Project#authorized_for_user?`, which does consider
    group links, so users with access to the project via a group link could
    see confidential issues on the index page. However, `IssuesPolicy` used
    `ProjectTeam#member?`, so the same user couldn't view the issue when
    going to it directly.
    db9979bc
    History
    Fix project member access for group links
    Sean McGivern authored
    `ProjectTeam#find_member` doesn't take group links into account. It was
    used in two places:
    
    1. An admin view - it can stay here.
    2. `ProjectTeam#member?`, which is often used to decide if a user has
       access to view something.
    
    This second part broke confidential issues viewing. `IssuesFinder` ends
    up delegating to `Project#authorized_for_user?`, which does consider
    group links, so users with access to the project via a group link could
    see confidential issues on the index page. However, `IssuesPolicy` used
    `ProjectTeam#member?`, so the same user couldn't view the issue when
    going to it directly.