Skip to content
Snippets Groups Projects
Select Git revision
  • master default protected
  • 12-9-stable
  • 12-7-stable
  • 12-6-stable
  • 12-8-stable
  • github/fork/Kloppi313/patch-1
  • 12-5-stable
  • 12-4-stable
  • github/fork/ramalokesh8477/master
  • 12-1-stable
  • 12-2-stable
  • 12-0-stable
  • 12-3-stable
  • 42-42-stable
  • github/fork/hussamgit398/patch-2
  • 12-3-auto-deploy-20190911
  • 12-3-auto-deploy-20190916
  • 12-3-auto-deploy-20190908
  • 12-3-auto-deploy-20190901
  • 12-3-auto-deploy-20190901-32664
  • v12.10.0.pre
  • v12.9.0
  • v12.9.0-rc42
  • v12.8.7
  • v12.8.6
  • v12.8.5
  • v12.8.4
  • v12.8.3
  • v12.6.8
  • v12.7.7
  • v12.8.2
  • v12.8.1
  • v12.9.0.pre
  • v12.8.0
  • v12.8.0-rc42
  • v12.5.10
  • v12.7.6
  • v12.6.7
  • v12.7.5
  • v12.5.9
40 results

44564-error-500-while-attempting-to-resolve-conflicts-due-to-utf-8-conversion-error.yml

  • Sean McGivern's avatar
    70af1e2e
    Fix 500 error when trying to resolve non-ASCII conflicts in editor · 70af1e2e
    Sean McGivern authored
    When we added caching, this meant that calling `can_be_resolved_in_ui?` didn't
    always call `lines`, which meant that we didn't get the benefit of the
    side-effect from that, where it forced the conflict data itself to UTF-8.
    
    To fix that, make this explicit by separating the `raw_content` (any encoding)
    from the `content` (which is either UTF-8, or an exception is raised).
    70af1e2e
    History
    Fix 500 error when trying to resolve non-ASCII conflicts in editor
    Sean McGivern authored
    When we added caching, this meant that calling `can_be_resolved_in_ui?` didn't
    always call `lines`, which meant that we didn't get the benefit of the
    side-effect from that, where it forced the conflict data itself to UTF-8.
    
    To fix that, make this explicit by separating the `raw_content` (any encoding)
    from the `content` (which is either UTF-8, or an exception is raised).