Skip to content
Snippets Groups Projects
Select Git revision
  • master default protected
  • 12-9-stable
  • 12-7-stable
  • 12-6-stable
  • 12-8-stable
  • github/fork/Kloppi313/patch-1
  • 12-5-stable
  • 12-4-stable
  • github/fork/ramalokesh8477/master
  • 12-1-stable
  • 12-2-stable
  • 12-0-stable
  • 12-3-stable
  • 42-42-stable
  • github/fork/hussamgit398/patch-2
  • 12-3-auto-deploy-20190911
  • 12-3-auto-deploy-20190916
  • 12-3-auto-deploy-20190908
  • 12-3-auto-deploy-20190901
  • 12-3-auto-deploy-20190901-32664
  • v12.10.0.pre
  • v12.9.0
  • v12.9.0-rc42
  • v12.8.7
  • v12.8.6
  • v12.8.5
  • v12.8.4
  • v12.8.3
  • v12.6.8
  • v12.7.7
  • v12.8.2
  • v12.8.1
  • v12.9.0.pre
  • v12.8.0
  • v12.8.0-rc42
  • v12.5.10
  • v12.7.6
  • v12.6.7
  • v12.7.5
  • v12.5.9
40 results

git_push_service.rb

  • Timothy Andrew's avatar
    dd3b738d
    Fix failing tests relating to backporting ee!581. · dd3b738d
    Timothy Andrew authored
    1. `GitPushService` was still using `{merge,push}_access_level_attributes` instead
       of `{merge,push}_access_levels_attributes`.
    
    2. The branches API creates access levels regardless of the state of the
       `developers_can_{push,merge}` parameters. This is in line with the UI,
       where Master access is the default for a new protected branch.
    
    3. Use `after(:build)` to create access levels in the
       `protected_branches` factory, so that `factories_spec` passes. It
       only builds records, so we need to create access levels on `build` as
       well.
    dd3b738d
    History
    Fix failing tests relating to backporting ee!581.
    Timothy Andrew authored
    1. `GitPushService` was still using `{merge,push}_access_level_attributes` instead
       of `{merge,push}_access_levels_attributes`.
    
    2. The branches API creates access levels regardless of the state of the
       `developers_can_{push,merge}` parameters. This is in line with the UI,
       where Master access is the default for a new protected branch.
    
    3. Use `after(:build)` to create access levels in the
       `protected_branches` factory, so that `factories_spec` passes. It
       only builds records, so we need to create access levels on `build` as
       well.