Skip to content
Snippets Groups Projects
Select Git revision
  • master default protected
  • 12-9-stable
  • 12-7-stable
  • 12-6-stable
  • 12-8-stable
  • github/fork/Kloppi313/patch-1
  • 12-5-stable
  • 12-4-stable
  • github/fork/ramalokesh8477/master
  • 12-1-stable
  • 12-2-stable
  • 12-0-stable
  • 12-3-stable
  • 42-42-stable
  • github/fork/hussamgit398/patch-2
  • 12-3-auto-deploy-20190911
  • 12-3-auto-deploy-20190916
  • 12-3-auto-deploy-20190908
  • 12-3-auto-deploy-20190901
  • 12-3-auto-deploy-20190901-32664
  • v12.10.0.pre
  • v12.9.0
  • v12.9.0-rc42
  • v12.8.7
  • v12.8.6
  • v12.8.5
  • v12.8.4
  • v12.8.3
  • v12.6.8
  • v12.7.7
  • v12.8.2
  • v12.8.1
  • v12.9.0.pre
  • v12.8.0
  • v12.8.0-rc42
  • v12.5.10
  • v12.7.6
  • v12.6.7
  • v12.7.5
  • v12.5.9
40 results

internal_spec.rb

  • Luke Duncalfe's avatar
    37492c5d
    Fix logic in Api::Internal test · 37492c5d
    Luke Duncalfe authored
    The intention of this test is to ensure that the service class
    MergeRequests::PushOptionsHandlerService does not run when the
    :mr_push_options feature flag is disabled.
    
    This test was passing, however was not testing what it was supposed to
    be!
    
    For one, setting Feature.disable(:feature) in the test does not disable
    the feature, as rspec config in spec_helper stubs Feature to make all
    features enabled:
    
    https://gitlab.com/gitlab-org/gitlab-ce/commit/3ee48e422defaedd69946c607bd8d3672e510375
    
    So the feature was still enabled in the test.
    
    But this test wasn't failing because unfortunately I had put:
    
    ```
    expect(MergeRequests::PushOptionsHandlerService).to receive(:new)
    ```
    
    instead of not_to!
    
    This meant that the `.new` method was being stubbed, so the service
    class did not create a MergeRequest, which satisfied the second
    expectation.
    
    ```
    expect(MergeRequests::PushOptionsHandlerService).to receive(:new)
    ```
    37492c5d
    History
    Fix logic in Api::Internal test
    Luke Duncalfe authored
    The intention of this test is to ensure that the service class
    MergeRequests::PushOptionsHandlerService does not run when the
    :mr_push_options feature flag is disabled.
    
    This test was passing, however was not testing what it was supposed to
    be!
    
    For one, setting Feature.disable(:feature) in the test does not disable
    the feature, as rspec config in spec_helper stubs Feature to make all
    features enabled:
    
    https://gitlab.com/gitlab-org/gitlab-ce/commit/3ee48e422defaedd69946c607bd8d3672e510375
    
    So the feature was still enabled in the test.
    
    But this test wasn't failing because unfortunately I had put:
    
    ```
    expect(MergeRequests::PushOptionsHandlerService).to receive(:new)
    ```
    
    instead of not_to!
    
    This meant that the `.new` method was being stubbed, so the service
    class did not create a MergeRequest, which satisfied the second
    expectation.
    
    ```
    expect(MergeRequests::PushOptionsHandlerService).to receive(:new)
    ```