Skip to content
Snippets Groups Projects
Select Git revision
  • master default protected
  • 12-9-stable
  • 12-7-stable
  • 12-6-stable
  • 12-8-stable
  • github/fork/Kloppi313/patch-1
  • 12-5-stable
  • 12-4-stable
  • github/fork/ramalokesh8477/master
  • 12-1-stable
  • 12-2-stable
  • 12-0-stable
  • 12-3-stable
  • 42-42-stable
  • github/fork/hussamgit398/patch-2
  • 12-3-auto-deploy-20190911
  • 12-3-auto-deploy-20190916
  • 12-3-auto-deploy-20190908
  • 12-3-auto-deploy-20190901
  • 12-3-auto-deploy-20190901-32664
  • v12.10.0.pre
  • v12.9.0
  • v12.9.0-rc42
  • v12.8.7
  • v12.8.6
  • v12.8.5
  • v12.8.4
  • v12.8.3
  • v12.6.8
  • v12.7.7
  • v12.8.2
  • v12.8.1
  • v12.9.0.pre
  • v12.8.0
  • v12.8.0-rc42
  • v12.5.10
  • v12.7.6
  • v12.6.7
  • v12.7.5
  • v12.5.9
40 results

import_export_uploader.rb

  • Stan Hu's avatar
    ec341a2b
    Clean up CarrierWave's import/export files · ec341a2b
    Stan Hu authored
    Unlike uploads that have been uploaded with Tempfile, the project
    import/export archives are stored in a temporary cache directory and
    remain there if:
    
    1. Object storage is enabled
    2. `move_to_store` is set to `true`.
    
    CarrierWave will leave these files there until disk space runs out or a
    clean step is run manually.
    
    If `move_to_store` is set to `false`, CarrierWave will remove the files
    after storing them. However, unlike a local file, with object storage,
    the file is still copied, so setting `move_to_store` to `true`
    doesn't buy us anything.
    
    To ensure files are cleaned up, we can just inherit from the
    GitlabUploader implementation of `move_to_store`, which returns `true`
    if it's a local file, `false` otherwise.
    
    Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/60656
    ec341a2b
    History
    Clean up CarrierWave's import/export files
    Stan Hu authored
    Unlike uploads that have been uploaded with Tempfile, the project
    import/export archives are stored in a temporary cache directory and
    remain there if:
    
    1. Object storage is enabled
    2. `move_to_store` is set to `true`.
    
    CarrierWave will leave these files there until disk space runs out or a
    clean step is run manually.
    
    If `move_to_store` is set to `false`, CarrierWave will remove the files
    after storing them. However, unlike a local file, with object storage,
    the file is still copied, so setting `move_to_store` to `true`
    doesn't buy us anything.
    
    To ensure files are cleaned up, we can just inherit from the
    GitlabUploader implementation of `move_to_store`, which returns `true`
    if it's a local file, `false` otherwise.
    
    Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/60656