Skip to content
Snippets Groups Projects
Select Git revision
  • master default protected
  • 12-9-stable
  • 12-7-stable
  • 12-6-stable
  • 12-8-stable
  • github/fork/Kloppi313/patch-1
  • 12-5-stable
  • 12-4-stable
  • github/fork/ramalokesh8477/master
  • 12-1-stable
  • 12-2-stable
  • 12-0-stable
  • 12-3-stable
  • 42-42-stable
  • github/fork/hussamgit398/patch-2
  • 12-3-auto-deploy-20190911
  • 12-3-auto-deploy-20190916
  • 12-3-auto-deploy-20190908
  • 12-3-auto-deploy-20190901
  • 12-3-auto-deploy-20190901-32664
  • v12.10.0.pre
  • v12.9.0
  • v12.9.0-rc42
  • v12.8.7
  • v12.8.6
  • v12.8.5
  • v12.8.4
  • v12.8.3
  • v12.6.8
  • v12.7.7
  • v12.8.2
  • v12.8.1
  • v12.9.0.pre
  • v12.8.0
  • v12.8.0-rc42
  • v12.5.10
  • v12.7.6
  • v12.6.7
  • v12.7.5
  • v12.5.9
40 results

projects_finder.rb

  • Yorick Peterse's avatar
    fbcf3bd3
    Refactor ProjectsFinder to not pluck IDs · fbcf3bd3
    Yorick Peterse authored
    This class now uses a UNION (when needed) instead of plucking tens of
    thousands of project IDs into memory. The tests have also been
    re-written to ensure all different use cases are tested properly
    (assuming I didn't forget any cases).
    
    The finder has also been broken up into 3 different finder classes:
    
    * ContributedProjectsFinder: class for getting the projects a user
      contributed to.
    * PersonalProjectsFinder: class for getting the personal projects of a
      user.
    * ProjectsFinder: class for getting generic projects visible to a given
      user.
    
    Previously a lot of the logic of these finders was handled directly in
    the users controller.
    fbcf3bd3
    History
    Refactor ProjectsFinder to not pluck IDs
    Yorick Peterse authored
    This class now uses a UNION (when needed) instead of plucking tens of
    thousands of project IDs into memory. The tests have also been
    re-written to ensure all different use cases are tested properly
    (assuming I didn't forget any cases).
    
    The finder has also been broken up into 3 different finder classes:
    
    * ContributedProjectsFinder: class for getting the projects a user
      contributed to.
    * PersonalProjectsFinder: class for getting the personal projects of a
      user.
    * ProjectsFinder: class for getting generic projects visible to a given
      user.
    
    Previously a lot of the logic of these finders was handled directly in
    the users controller.