Add latest changes from gitlab-org/gitlab@master

spec/models/project_services/youtrack_service_spec.rb

@@ -38,8 +38,8 @@ describe YoutrackService do
       expect(described_class.reference_pattern.match('YT-123')[:issue]).to eq('YT-123')
     end
-    it 'does not allow issue number to be followed by a letter' do
-      expect(described_class.reference_pattern.match('YT-123A')).to eq(nil)
+    it 'allows lowercase project key on the reference' do
+      expect(described_class.reference_pattern.match('yt-123')[:issue]).to eq('yt-123')
     end
   end

spec/support/shared_examples/models/issue_tracker_service_shared_examples.rb

@@ -21,4 +21,8 @@ RSpec.shared_examples 'allows project key on reference pattern' do |url_attr|
     expect(described_class.reference_pattern.match('3EXT_EXT-1234')).to eq nil
     expect(described_class.reference_pattern.match('EXT_EXT-1234')[0]).to eq 'EXT_EXT-1234'
   end
+
+  it 'does not allow issue number to finish with a letter' do
+    expect(described_class.reference_pattern.match('EXT-123A')).to eq(nil)
+  end
 end