Skip to content
Snippets Groups Projects
Commit 0e701c13 authored by Samantha Ming's avatar Samantha Ming Committed by Phil Hughes
Browse files

Fix incorrect reaction placement in commit diff discussion

parent ec5137f6
No related branches found
No related tags found
No related merge requests found
Loading
Loading
@@ -39,7 +39,7 @@
- if can?(current_user, :award_emoji, note)
- if note.emoji_awardable?
.note-actions-item
= button_tag title: 'Add reaction', class: "note-action-button note-emoji-button js-add-award js-note-emoji} has-tooltip btn btn-transparent", data: { position: 'right', container: 'body' } do
= button_tag title: 'Add reaction', class: "note-action-button note-emoji-button js-add-award js-note-emoji has-tooltip btn btn-transparent", data: { position: 'right', container: 'body' } do
= icon('spinner spin')
%span{ class: 'link-highlight award-control-icon-neutral' }= sprite_icon('slight-smile')
%span{ class: 'link-highlight award-control-icon-positive' }= sprite_icon('smiley')
Loading
Loading
---
title: Fix incorrect emoji placement in commit diff discussion
merge_request: 29445
author:
type: fixed
Loading
Loading
@@ -6,6 +6,8 @@ describe 'Discussion Comments Commit', :js do
let(:user) { create(:user) }
let(:project) { create(:project, :repository) }
let(:merge_request) { create(:merge_request, source_project: project) }
let!(:commit_discussion_note1) { create(:discussion_note_on_commit, project: project) }
let!(:commit_discussion_note2) { create(:discussion_note_on_commit, in_reply_to: commit_discussion_note1) }
 
before do
project.add_maintainer(user)
Loading
Loading
@@ -15,4 +17,18 @@ describe 'Discussion Comments Commit', :js do
end
 
it_behaves_like 'discussion comments', 'commit'
it 'has class .js-note-emoji' do
expect(page).to have_css('.js-note-emoji')
end
it 'adds award to the correct note' do
find("#note_#{commit_discussion_note2.id} .js-note-emoji").click
first('.emoji-menu .js-emoji-btn').click
wait_for_requests
expect(find("#note_#{commit_discussion_note1.id}")).not_to have_css('.js-awards-block')
expect(find("#note_#{commit_discussion_note2.id}")).to have_css('.js-awards-block')
end
end
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment