Skip to content
Snippets Groups Projects
Commit 100c687c authored by Sergey Sinev's avatar Sergey Sinev Committed by Stan Hu
Browse files

Fix error when deleting an empty list of refs

Closes #45743
parent 8bacfbd1
No related branches found
No related tags found
No related merge requests found
---
title: Fix error when deleting an empty list of refs
merge_request:
author:
type: fixed
Loading
Loading
@@ -2346,7 +2346,7 @@ module Gitlab
end
 
def gitaly_delete_refs(*ref_names)
gitaly_ref_client.delete_refs(refs: ref_names)
gitaly_ref_client.delete_refs(refs: ref_names) if ref_names.any?
end
 
def rugged_remove_remote(remote_name)
Loading
Loading
Loading
Loading
@@ -600,6 +600,10 @@ describe Gitlab::Git::Repository, seed_helper: true do
end
end
 
it 'does not fail when deleting an empty list of refs' do
expect { repo.delete_refs(*[]) }.not_to raise_error
end
it 'raises an error if it failed' do
expect { repo.delete_refs('refs\heads\fix') }.to raise_error(Gitlab::Git::Repository::GitError)
end
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment