Merge branch 'psimyn-incident-report-section-ce' into 'master'

CE backport of Add Incidents section to Operations settings

See merge request gitlab-org/gitlab-ce!25939

app/assets/stylesheets/pages/settings.scss

@@ -23,7 +23,10 @@
 }
 .settings {
-  border-bottom: 1px solid $gray-darker;
+  // border-top for each item except the top one
+  + .settings {
+    border-top: 1px solid $border-color;
+  }
   &:first-of-type {
     margin-top: 10px;

app/views/projects/settings/operations/_error_tracking.html.haml

@@ -2,7 +2,7 @@
 - setting = error_tracking_setting
-%section.settings.expanded.border-0.no-animate
+%section.settings.expanded.no-animate
   .settings-header
     %h4
       = _('Error Tracking')

app/views/projects/settings/operations/show.html.haml

@@ -2,5 +2,6 @@
 - page_title _('Operations Settings')
 - breadcrumb_title _('Operations Settings')
+= render_if_exists 'projects/settings/operations/incidents'
 = render 'projects/settings/operations/error_tracking', expanded: true
 = render_if_exists 'projects/settings/operations/tracing'

spec/views/projects/settings/operations/show.html.haml_spec.rb

@@ -18,6 +18,7 @@ describe 'projects/settings/operations/show' do
       allow(view).to receive(:error_tracking_setting)
         .and_return(error_tracking_setting)
       allow(view).to receive(:current_user).and_return(user)
+      allow(view).to receive(:incident_management_available?) { false }
     end
     let!(:error_tracking_setting) do