Enable more frozen string in app/models/**/*.rb

Partially addresses #47424.

app/models/concerns/access_requestable.rb

+# frozen_string_literal: true
+
 # == AccessRequestable concern
 #
 # Contains functionality related to objects that can receive request for access.

app/models/concerns/artifact_migratable.rb

+# frozen_string_literal: true
+
 # Adapter class to unify the interface between mounted uploaders and the
 # Ci::Artifact model
 # Meant to be prepended so the interface can stay the same

app/models/concerns/atomic_internal_id.rb

+# frozen_string_literal: true
+
 # Include atomic internal id generation scheme for a model
 #
 # This allows us to atomically generate internal ids that are

app/models/concerns/avatarable.rb

+# frozen_string_literal: true
+
 module Avatarable
   extend ActiveSupport::Concern
@@ -57,7 +59,8 @@ module Avatarable
       only_path = false
     end
-    url_base = ""
+    url_base = []
+
     if use_asset_host
       url_base << asset_host unless only_path
     else
@@ -65,7 +68,7 @@ module Avatarable
       url_base << gitlab_config.relative_url_root
     end
-    url_base + avatar.local_url + query_params
+    url_base.join + avatar.local_url + query_params
   end
   # Path that is persisted in the tracking Upload model. Used to fetch the

app/models/concerns/awardable.rb

+# frozen_string_literal: true
+
 module Awardable
   extend ActiveSupport::Concern

app/models/concerns/batch_destroy_dependent_associations.rb

+# frozen_string_literal: true
+
 # Provides a way to work around Rails issue where dependent objects are all
 # loaded into memory before destroyed: https://github.com/rails/rails/issues/22510.
 #

app/models/concerns/blob_like.rb

+# frozen_string_literal: true
+
 module BlobLike
   extend ActiveSupport::Concern
   include Linguist::BlobHelper

app/models/concerns/blocks_json_serialization.rb

+# frozen_string_literal: true
+
 # Overrides `as_json` and `to_json` to raise an exception when called in order
 # to prevent accidentally exposing attributes
 #

app/models/concerns/bulk_member_access_load.rb

+# frozen_string_literal: true
+
 # Returns and caches in thread max member access for a resource
 #
 module BulkMemberAccessLoad

app/models/concerns/cache_markdown_field.rb

+# frozen_string_literal: true
+
 # This module takes care of updating cache columns for Markdown-containing
 # fields. Use like this in the body of your class:
 #

app/models/concerns/cacheable_attributes.rb

+# frozen_string_literal: true
+
 module CacheableAttributes
   extend ActiveSupport::Concern

app/models/concerns/case_sensitivity.rb

+# frozen_string_literal: true
+
 # Concern for querying columns with specific case sensitivity handling.
 module CaseSensitivity
   extend ActiveSupport::Concern

app/models/concerns/chronic_duration_attribute.rb

+# frozen_string_literal: true
+
 module ChronicDurationAttribute
   extend ActiveSupport::Concern

app/models/concerns/created_at_filterable.rb

+# frozen_string_literal: true
+
 module CreatedAtFilterable
   extend ActiveSupport::Concern

app/models/concerns/deployment_platform.rb

+# frozen_string_literal: true
+
 module DeploymentPlatform
   # EE would override this and utilize environment argument
   # rubocop:disable Gitlab/ModuleWithInstanceVariables

app/models/concerns/diff_file.rb

+# frozen_string_literal: true
+
 module DiffFile
   extend ActiveSupport::Concern

app/models/concerns/discussion_on_diff.rb

+# frozen_string_literal: true
+
 # Contains functionality shared between `DiffDiscussion` and `LegacyDiffDiscussion`.
 module DiscussionOnDiff
   extend ActiveSupport::Concern

app/models/concerns/each_batch.rb

+# frozen_string_literal: true
+
 module EachBatch
   extend ActiveSupport::Concern

app/models/concerns/editable.rb

+# frozen_string_literal: true
+
 module Editable
   extend ActiveSupport::Concern

app/models/concerns/enum_with_nil.rb

+# frozen_string_literal: true
+
 module EnumWithNil
   extend ActiveSupport::Concern