Use `empty_project` where possible in spec/features/projects

spec/features/projects/artifacts/browse_spec.rb

 require 'spec_helper'
 feature 'Browse artifact', :js do
-  let(:project) { create(:project, :public) }
-  let(:pipeline) { create(:ci_empty_pipeline, project: project, sha: project.commit.sha, ref: 'master') }
+  let(:project) { create(:empty_project, :public) }
+  let(:pipeline) { create(:ci_empty_pipeline, project: project) }
   let(:job) { create(:ci_build, :artifacts, pipeline: pipeline) }
   def browse_path(path)

spec/features/projects/artifacts/download_spec.rb

 require 'spec_helper'
 feature 'Download artifact', :js do
-  let(:project) { create(:project, :public) }
-  let(:pipeline) { create(:ci_empty_pipeline, status: :success, project: project, sha: project.commit.sha, ref: 'master') }
+  let(:project) { create(:empty_project, :public) }
+  let(:pipeline) { create(:ci_empty_pipeline, status: :success, project: project) }
   let(:job) { create(:ci_build, :artifacts, :success, pipeline: pipeline) }
   shared_examples 'downloading' do

spec/features/projects/artifacts/file_spec.rb

 require 'spec_helper'
 feature 'Artifact file', :js do
-  let(:project) { create(:project, :public) }
-  let(:pipeline) { create(:ci_empty_pipeline, project: project, sha: project.commit.sha, ref: 'master') }
+  let(:project) { create(:empty_project, :public) }
+  let(:pipeline) { create(:ci_empty_pipeline, project: project) }
   let(:build) { create(:ci_build, :artifacts, pipeline: pipeline) }
   def visit_file(path)

spec/features/projects/artifacts/raw_spec.rb

 require 'spec_helper'
 feature 'Raw artifact', :js do
-  let(:project) { create(:project, :public) }
-  let(:pipeline) { create(:ci_empty_pipeline, project: project, sha: project.commit.sha, ref: 'master') }
+  let(:project) { create(:empty_project, :public) }
+  let(:pipeline) { create(:ci_empty_pipeline, project: project) }
   let(:job) { create(:ci_build, :artifacts, pipeline: pipeline) }
   def raw_path(path)

spec/features/projects/badges/coverage_spec.rb

@@ -2,7 +2,7 @@ require 'spec_helper'
 feature 'test coverage badge' do
   given!(:user) { create(:user) }
-  given!(:project) { create(:project, :private) }
+  given!(:project) { create(:empty_project, :private) }
   context 'when user has access to view badge' do
     background do
@@ -55,7 +55,7 @@ feature 'test coverage badge' do
   end
   def create_pipeline
-    opts = { project: project, ref: 'master', sha: project.commit.id }
+    opts = { project: project }
     create(:ci_pipeline, opts).tap do |pipeline|
       yield pipeline

spec/features/projects/badges/list_spec.rb

@@ -3,7 +3,7 @@ require 'spec_helper'
 feature 'list of badges' do
   background do
     user = create(:user)
-    project = create(:project)
+    project = create(:project, :repository)
     project.team << [user, :master]
     sign_in(user)
     visit project_pipelines_settings_path(project)

spec/features/projects/blobs/blob_show_spec.rb

 require 'spec_helper'
 feature 'File blob', :js do
-  let(:project) { create(:project, :public) }
+  let(:project) { create(:project, :public, :repository) }
   def visit_blob(path, anchor: nil, ref: 'master')
     visit project_blob_path(project, File.join(ref, path), anchor: anchor)

spec/features/projects/branches/download_buttons_spec.rb

@@ -4,7 +4,7 @@ feature 'Download buttons in branches page' do
   given(:user) { create(:user) }
   given(:role) { :developer }
   given(:status) { 'success' }
-  given(:project) { create(:project) }
+  given(:project) { create(:project, :repository) }
   given(:pipeline) do
     create(:ci_pipeline,

spec/features/projects/branches/new_branch_ref_dropdown_spec.rb

@@ -2,7 +2,7 @@ require 'spec_helper'
 describe 'New Branch Ref Dropdown', :js do
   let(:user) { create(:user) }
-  let(:project) { create(:project, :public) }
+  let(:project) { create(:project, :public, :repository) }
   let(:toggle) { find('.create-from .dropdown-menu-toggle') }
   before do

spec/features/projects/branches_spec.rb

@@ -2,7 +2,7 @@ require 'spec_helper'
 describe 'Branches' do
   let(:user) { create(:user) }
-  let(:project) { create(:project, :public) }
+  let(:project) { create(:project, :public, :repository) }
   let(:repository) { project.repository }
   def set_protected_branch_name(branch_name)

spec/features/projects/commit/builds_spec.rb

 require 'spec_helper'
 feature 'project commit pipelines', js: true do
-  given(:project) { create(:project) }
+  given(:project) { create(:project, :repository) }
   background do
     user = create(:user)

spec/features/projects/commit/cherry_pick_spec.rb

@@ -3,7 +3,7 @@ require 'spec_helper'
 describe 'Cherry-pick Commits' do
   let(:user) { create(:user) }
   let(:group) { create(:group) }
-  let(:project) { create(:project, namespace: group) }
+  let(:project) { create(:project, :repository, namespace: group) }
   let(:master_pickable_commit)  { project.commit('7d3b0f7cff5f37573aea97cebfd5692ea1689924') }
   let(:master_pickable_merge)  { project.commit('e56497bb5f03a90a51293fc6d516788730953899') }

spec/features/projects/commit/mini_pipeline_graph_spec.rb

@@ -2,7 +2,7 @@ require 'rails_helper'
 feature 'Mini Pipeline Graph in Commit View', :js do
   let(:user) { create(:user) }
-  let(:project) { create(:project, :public) }
+  let(:project) { create(:project, :public, :repository) }
   before do
     sign_in(user)

spec/features/projects/compare_spec.rb

@@ -2,7 +2,7 @@ require "spec_helper"
 describe "Compare", js: true do
   let(:user)    { create(:user) }
-  let(:project) { create(:project) }
+  let(:project) { create(:project, :repository) }
   before do
     project.team << [user, :master]

spec/features/projects/edit_spec.rb

@@ -2,7 +2,7 @@ require 'rails_helper'
 feature 'Project edit', js: true do
   let(:user)    { create(:user) }
-  let(:project) { create(:project) }
+  let(:project) { create(:empty_project) }
   before do
     project.team << [user, :master]
@@ -20,7 +20,7 @@ feature 'Project edit', js: true do
       end
       context 'given project with merge_requests_disabled access level' do
-        let(:project) { create(:project, :merge_requests_disabled) }
+        let(:project) { create(:empty_project, :merge_requests_disabled) }
         it 'hides merge requests section' do
           expect(page).to have_selector('.merge-requests-feature', visible: false)
@@ -36,7 +36,7 @@ feature 'Project edit', js: true do
       end
       context 'given project with builds_disabled access level' do
-        let(:project) { create(:project, :builds_disabled) }
+        let(:project) { create(:empty_project, :builds_disabled) }
         it 'hides builds select section' do
           expect(page).to have_selector('.builds-feature', visible: false)

spec/features/projects/environments/environment_spec.rb

@@ -205,7 +205,7 @@ feature 'Environment' do
   end
   feature 'auto-close environment when branch is deleted' do
-    given(:project) { create(:project) }
+    given(:project) { create(:project, :repository) }
     given!(:environment) do
       create(:environment, :with_review_app, project: project,

spec/features/projects/environments/environments_spec.rb

@@ -111,7 +111,7 @@ feature 'Environments page', :js do
     end
     context 'with deployments' do
-      given(:project) { create(:project) }
+      given(:project) { create(:project, :repository) }
       given(:deployment) do
         create(:deployment, environment: environment,

spec/features/projects/features_visibility_spec.rb

@@ -2,7 +2,7 @@ require 'spec_helper'
 describe 'Edit Project Settings' do
   let(:member) { create(:user) }
-  let!(:project) { create(:project, :public, path: 'gitlab', name: 'sample') }
+  let!(:project) { create(:project, :public, :repository) }
   let!(:issue) { create(:issue, project: project) }
   let(:non_member) { create(:user) }
@@ -249,7 +249,7 @@ describe 'Edit Project Settings' do
   # Regression spec for https://gitlab.com/gitlab-org/gitlab-ce/issues/24056
   describe 'project statistic visibility' do
-    let!(:project) { create(:project, :private) }
+    let!(:project) { create(:empty_project, :private) }
     before do
       project.team << [member, :guest]

spec/features/projects/files/browse_files_spec.rb

 require 'spec_helper'
 feature 'user browses project', js: true do
-  let(:project) { create(:project) }
+  let(:project) { create(:project, :repository) }
   let(:user) { create(:user) }
   before do

spec/features/projects/files/creating_a_file_spec.rb

 require 'spec_helper'
 feature 'User wants to create a file' do
-  let(:project) { create(:project) }
+  let(:project) { create(:project, :repository) }
   let(:user) { create(:user) }
   background do