Destroy all related todos when removing a project

CHANGELOG

@@ -16,6 +16,9 @@ v 8.6.0 (unreleased)
   - Increase the notes polling timeout over time (Roberto Dip)
   - Show labels in dashboard and group milestone views
+v 8.5.5
+  - Fix: Destroy all related todos when removing a project
+
 v 8.5.4
   - Do not cache requests for badges (including builds badge)

app/models/project.rb

@@ -151,6 +151,7 @@ class Project < ActiveRecord::Base
   has_many :releases, dependent: :destroy
   has_many :lfs_objects_projects, dependent: :destroy
   has_many :lfs_objects, through: :lfs_objects_projects
+  has_many :todos, dependent: :destroy
   has_one :import_data, dependent: :destroy, class_name: "ProjectImportData"

db/migrate/20160308040034_fix_todos.rb

+class FixTodos < ActiveRecord::Migration
+  def up
+    execute <<-SQL
+      DELETE FROM todos
+      WHERE NOT EXISTS (
+        SELECT *
+        FROM projects
+        WHERE projects.id = todos.id
+      )
+    SQL
+  end
+
+  def down
+  end
+end

db/schema.rb

@@ -11,7 +11,7 @@
 #
 # It's strongly recommended that you check this file into your version control system.
-ActiveRecord::Schema.define(version: 20160222153918) do
+ActiveRecord::Schema.define(version: 20160308040034) do
   # These are extensions that must be enabled in order to support this database
   enable_extension "plpgsql"

spec/models/project_spec.rb

@@ -68,6 +68,7 @@ describe Project, models: true do
     it { is_expected.to have_many(:runners) }
     it { is_expected.to have_many(:variables) }
     it { is_expected.to have_many(:triggers) }
+    it { is_expected.to have_many(:todos).dependent(:destroy) }
   end
   describe 'modules' do