Avoid calling freeze on already frozen strings in app/models

app/models/namespace/aggregation_schedule.rb

@@ -7,7 +7,7 @@ class Namespace::AggregationSchedule < ApplicationRecord
   self.primary_key = :namespace_id
   DEFAULT_LEASE_TIMEOUT = 1.5.hours.to_i
-  REDIS_SHARED_KEY = 'gitlab:update_namespace_statistics_delay'.freeze
+  REDIS_SHARED_KEY = 'gitlab:update_namespace_statistics_delay'
   belongs_to :namespace

app/models/notification_reason.rb

@@ -3,9 +3,9 @@
 # Holds reasons for a notification to have been sent as well as a priority list to select which reason to use
 # above the rest
 class NotificationReason
-  OWN_ACTIVITY = 'own_activity'.freeze
-  ASSIGNED = 'assigned'.freeze
-  MENTIONED = 'mentioned'.freeze
+  OWN_ACTIVITY = 'own_activity'
+  ASSIGNED = 'assigned'
+  MENTIONED = 'mentioned'
   # Priority list for selecting which reason to return in the notification
   REASON_PRIORITY = [

app/models/pages_domain.rb

 # frozen_string_literal: true
 class PagesDomain < ApplicationRecord
-  VERIFICATION_KEY = 'gitlab-pages-verification-code'.freeze
+  VERIFICATION_KEY = 'gitlab-pages-verification-code'
   VERIFICATION_THRESHOLD = 3.days.freeze
   SSL_RENEWAL_THRESHOLD = 30.days.freeze

app/models/project.rb

@@ -37,8 +37,8 @@ class Project < ApplicationRecord
   BoardLimitExceeded = Class.new(StandardError)
-  STATISTICS_ATTRIBUTE = 'repositories_count'.freeze
-  UNKNOWN_IMPORT_URL = 'http://unknown.git'.freeze
+  STATISTICS_ATTRIBUTE = 'repositories_count'
+  UNKNOWN_IMPORT_URL = 'http://unknown.git'
   # Hashed Storage versions handle rolling out new storage to project and dependents models:
   # nil: legacy
   # 1: repository

app/models/project_services/buildkite_service.rb

@@ -5,7 +5,7 @@ require "addressable/uri"
 class BuildkiteService < CiService
   include ReactiveService
-  ENDPOINT = "https://buildkite.com".freeze
+  ENDPOINT = "https://buildkite.com"
   prop_accessor :project_url, :token
   boolean_accessor :enable_ssl_verification

app/models/project_services/pivotaltracker_service.rb

 # frozen_string_literal: true
 class PivotaltrackerService < Service
-  API_ENDPOINT = 'https://www.pivotaltracker.com/services/v5/source_commits'.freeze
+  API_ENDPOINT = 'https://www.pivotaltracker.com/services/v5/source_commits'
   prop_accessor :token, :restrict_to_branch
   validates :token, presence: true, if: :activated?

app/models/project_services/pushover_service.rb

 # frozen_string_literal: true
 class PushoverService < Service
-  BASE_URI = 'https://api.pushover.net/1'.freeze
+  BASE_URI = 'https://api.pushover.net/1'
   prop_accessor :api_key, :user_key, :device, :priority, :sound
   validates :api_key, :user_key, :priority, presence: true, if: :activated?

app/models/repository.rb

@@ -3,9 +3,9 @@
 require 'securerandom'
 class Repository
-  REF_MERGE_REQUEST = 'merge-requests'.freeze
-  REF_KEEP_AROUND = 'keep-around'.freeze
-  REF_ENVIRONMENTS = 'environments'.freeze
+  REF_MERGE_REQUEST = 'merge-requests'
+  REF_KEEP_AROUND = 'keep-around'
+  REF_ENVIRONMENTS = 'environments'
   ARCHIVE_CACHE_TIME = 60 # Cache archives referred to by a (mutable) ref for 1 minute
   ARCHIVE_CACHE_TIME_IMMUTABLE = 3600 # Cache archives referred to by an immutable reference for 1 hour

app/models/user.rb

@@ -59,7 +59,7 @@ class User < ApplicationRecord
          :validatable, :omniauthable, :confirmable, :registerable
   BLOCKED_MESSAGE = "Your account has been blocked. Please contact your GitLab " \
-                    "administrator if you think this is an error.".freeze
+                    "administrator if you think this is an error."
   # Override Devise::Models::Trackable#update_tracked_fields!
   # to limit database writes to at most once every hour
@@ -494,7 +494,7 @@ class User < ApplicationRecord
     def by_login(login)
       return unless login
-      if login.include?('@'.freeze)
+      if login.include?('@')
         unscoped.iwhere(email: login).take
       else
         unscoped.iwhere(username: login).take

app/models/user_status.rb

@@ -5,7 +5,7 @@ class UserStatus < ApplicationRecord
   self.primary_key = :user_id
-  DEFAULT_EMOJI = 'speech_balloon'.freeze
+  DEFAULT_EMOJI = 'speech_balloon'
   belongs_to :user