Skip to content
Snippets Groups Projects
Verified Commit 20c2e902 authored by Dmitriy Zaporozhets's avatar Dmitriy Zaporozhets
Browse files

Refactor finders. Prevent circular dependency error

parent 9ccef9a7
No related branches found
No related tags found
No related merge requests found
# BaseFinder
# IssuableFinder
#
# Used to filter Issues and MergeRequests collections by set of params
#
Loading
Loading
@@ -16,7 +16,9 @@
# label_name: string
# sort: string
#
class BaseFinder
require_relative 'projects_finder'
class IssuableFinder
attr_accessor :current_user, :params
 
def execute(current_user, params)
Loading
Loading
Loading
Loading
@@ -15,7 +15,7 @@
# label_name: string
# sort: string
#
class IssuesFinder < BaseFinder
class IssuesFinder < IssuableFinder
def klass
Issue
end
Loading
Loading
Loading
Loading
@@ -15,7 +15,7 @@
# label_name: string
# sort: string
#
class MergeRequestsFinder < BaseFinder
class MergeRequestsFinder < IssuableFinder
def klass
MergeRequest
end
Loading
Loading
Loading
Loading
@@ -6,9 +6,9 @@ module API
helpers do
def filter_issues_state(issues, state = nil)
case state
when 'opened' then issues.opened
when 'closed' then issues.closed
else issues
when 'opened' then issues.opened
when 'closed' then issues.closed
else issues
end
end
end
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment