Skip to content
Snippets Groups Projects
Unverified Commit 247bd122 authored by Francisco Javier López's avatar Francisco Javier López
Browse files

Changed external wiki query method to prevent attribute caching

parent 6b0b14f8
No related branches found
No related tags found
No related merge requests found
Loading
Loading
@@ -328,7 +328,7 @@ module ProjectsHelper
def external_nav_tabs(project)
[].tap do |tabs|
tabs << :external_issue_tracker if project.external_issue_tracker
tabs << :external_wiki if project.has_external_wiki?
tabs << :external_wiki if project.external_wiki
end
end
 
Loading
Loading
---
title: Changed external wiki query method to prevent attribute caching
merge_request: 24907
author:
type: fixed
Loading
Loading
@@ -372,21 +372,16 @@ describe ProjectsHelper do
end
 
context 'when project has external wiki' do
before do
allow(project).to receive(:has_external_wiki?).and_return(true)
end
it 'includes external wiki tab' do
project.create_external_wiki_service(active: true, properties: { 'external_wiki_url' => 'https://gitlab.com' })
is_expected.to include(:external_wiki)
end
end
 
context 'when project does not have external wiki' do
before do
allow(project).to receive(:has_external_wiki?).and_return(false)
end
it 'does not include external wiki tab' do
expect(project.external_wiki).to be_nil
is_expected.not_to include(:external_wiki)
end
end
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment