Merge branch '40855_remove_authentication_in_readonly_issue_api' into 'master'

Remove authentication for readonly endpoints in issues API

Closes #40855

See merge request gitlab-org/gitlab-ce!18638

changelogs/unreleased/40855_remove_authentication_in_readonly_issue_api.yml

+---
+title: made listing and showing public issue apis available without authentication
+merge_request: 18638
+author: haseebeqx
+type: changed

lib/api/issues.rb

@@ -2,7 +2,7 @@ module API
   class Issues < Grape::API
     include PaginationParams
-    before { authenticate! }
+    before { authenticate_non_get! }
     helpers ::Gitlab::IssuableMetadata
@@ -70,6 +70,7 @@ module API
                          desc: 'Return issues for the given scope: `created-by-me`, `assigned-to-me` or `all`'
       end
       get do
+        authenticate! unless params[:scope] == 'all'
         issues = paginate(find_issues)
         options = {

spec/requests/api/issues_spec.rb

@@ -64,12 +64,32 @@ describe API::Issues do
   describe "GET /issues" do
     context "when unauthenticated" do
-      it "returns authentication error" do
+      it "returns an array of all issues" do
+        get api("/issues"), scope: 'all'
+
+        expect(response).to have_http_status(200)
+        expect(json_response).to be_an Array
+      end
+
+      it "returns authentication error without any scope" do
         get api("/issues")
-        expect(response).to have_gitlab_http_status(401)
+        expect(response).to have_http_status(401)
+      end
+
+      it "returns authentication error when scope is assigned-to-me" do
+        get api("/issues"), scope: 'assigned-to-me'
+
+        expect(response).to have_http_status(401)
+      end
+
+      it "returns authentication error when scope is created-by-me" do
+        get api("/issues"), scope: 'created-by-me'
+
+        expect(response).to have_http_status(401)
       end
     end
+
     context "when authenticated" do
       let(:first_issue) { json_response.first }
@@ -379,9 +399,6 @@ describe API::Issues do
     end
     let!(:group_note) { create(:note_on_issue, author: user, project: group_project, noteable: group_issue) }
-    before do
-      group_project.add_reporter(user)
-    end
     let(:base_url) { "/groups/#{group.id}/issues" }
     context 'when group has subgroups', :nested_groups do
@@ -408,178 +425,201 @@ describe API::Issues do
       end
     end
-    it 'returns all group issues (including opened and closed)' do
-      get api(base_url, admin)
-      expect_paginated_array_response(size: 3)
+    context 'when user is unauthenticated' do
+      it 'lists all issues in public projects' do
+        get api(base_url)
+        expect_paginated_array_response(size: 2)
+      end
     end
-    it 'returns group issues without confidential issues for non project members' do
-      get api("#{base_url}?state=opened", non_member)
-      expect_paginated_array_response(size: 1)
-      expect(json_response.first['title']).to eq(group_issue.title)
-    end
-    it 'returns group confidential issues for author' do
-      get api("#{base_url}?state=opened", author)
-      expect_paginated_array_response(size: 2)
-    end
-    it 'returns group confidential issues for assignee' do
-      get api("#{base_url}?state=opened", assignee)
-      expect_paginated_array_response(size: 2)
-    end
-    it 'returns group issues with confidential issues for project members' do
-      get api("#{base_url}?state=opened", user)
-      expect_paginated_array_response(size: 2)
-    end
-    it 'returns group confidential issues for admin' do
-      get api("#{base_url}?state=opened", admin)
-      expect_paginated_array_response(size: 2)
-    end
-    it 'returns an array of labeled group issues' do
-      get api("#{base_url}?labels=#{group_label.title}", user)
-      expect_paginated_array_response(size: 1)
-      expect(json_response.first['labels']).to eq([group_label.title])
-    end
-    it 'returns an array of labeled group issues where all labels match' do
-      get api("#{base_url}?labels=#{group_label.title},foo,bar", user)
-      expect_paginated_array_response(size: 0)
-    end
-    it 'returns issues matching given search string for title' do
-      get api("#{base_url}?search=#{group_issue.title}", user)
-      expect_paginated_array_response(size: 1)
-      expect(json_response.first['id']).to eq(group_issue.id)
-    end
-    it 'returns issues matching given search string for description' do
-      get api("#{base_url}?search=#{group_issue.description}", user)
-      expect_paginated_array_response(size: 1)
-      expect(json_response.first['id']).to eq(group_issue.id)
-    end
-    it 'returns an array of labeled issues when all labels matches' do
-      label_b = create(:label, title: 'foo', project: group_project)
-      label_c = create(:label, title: 'bar', project: group_project)
-      create(:label_link, label: label_b, target: group_issue)
-      create(:label_link, label: label_c, target: group_issue)
-      get api("#{base_url}", user), labels: "#{group_label.title},#{label_b.title},#{label_c.title}"
-      expect_paginated_array_response(size: 1)
-      expect(json_response.first['labels']).to eq([label_c.title, label_b.title, group_label.title])
-    end
-    it 'returns an array of issues found by iids' do
-      get api(base_url, user), iids: [group_issue.iid]
-      expect_paginated_array_response(size: 1)
-      expect(json_response.first['id']).to eq(group_issue.id)
-    end
-    it 'returns an empty array if iid does not exist' do
-      get api(base_url, user), iids: [99999]
-      expect_paginated_array_response(size: 0)
-    end
-    it 'returns an empty array if no group issue matches labels' do
-      get api("#{base_url}?labels=foo,bar", user)
-      expect_paginated_array_response(size: 0)
-    end
-    it 'returns an empty array if no issue matches milestone' do
-      get api("#{base_url}?milestone=#{group_empty_milestone.title}", user)
-      expect_paginated_array_response(size: 0)
-    end
-    it 'returns an empty array if milestone does not exist' do
-      get api("#{base_url}?milestone=foo", user)
-      expect_paginated_array_response(size: 0)
-    end
-    it 'returns an array of issues in given milestone' do
-      get api("#{base_url}?state=opened&milestone=#{group_milestone.title}", user)
-      expect_paginated_array_response(size: 1)
-      expect(json_response.first['id']).to eq(group_issue.id)
-    end
-    it 'returns an array of issues matching state in milestone' do
-      get api("#{base_url}?milestone=#{group_milestone.title}"\
-              '&state=closed', user)
-      expect_paginated_array_response(size: 1)
-      expect(json_response.first['id']).to eq(group_closed_issue.id)
-    end
-    it 'returns an array of issues with no milestone' do
-      get api("#{base_url}?milestone=#{no_milestone_title}", user)
-      expect(response).to have_gitlab_http_status(200)
-      expect_paginated_array_response(size: 1)
-      expect(json_response.first['id']).to eq(group_confidential_issue.id)
-    end
-    it 'sorts by created_at descending by default' do
-      get api(base_url, user)
-      response_dates = json_response.map { |issue| issue['created_at'] }
-      expect_paginated_array_response(size: 3)
-      expect(response_dates).to eq(response_dates.sort.reverse)
-    end
-    it 'sorts ascending when requested' do
-      get api("#{base_url}?sort=asc", user)
-      response_dates = json_response.map { |issue| issue['created_at'] }
-      expect_paginated_array_response(size: 3)
-      expect(response_dates).to eq(response_dates.sort)
-    end
-    it 'sorts by updated_at descending when requested' do
-      get api("#{base_url}?order_by=updated_at", user)
-      response_dates = json_response.map { |issue| issue['updated_at'] }
-      expect_paginated_array_response(size: 3)
-      expect(response_dates).to eq(response_dates.sort.reverse)
-    end
-    it 'sorts by updated_at ascending when requested' do
-      get api("#{base_url}?order_by=updated_at&sort=asc", user)
-      response_dates = json_response.map { |issue| issue['updated_at'] }
-      expect_paginated_array_response(size: 3)
-      expect(response_dates).to eq(response_dates.sort)
+    context 'when user is a group member' do
+      before do
+        group_project.add_reporter(user)
+      end
+      it 'returns all group issues (including opened and closed)' do
+        get api(base_url, admin)
+        expect_paginated_array_response(size: 3)
+      end
+      it 'returns group issues without confidential issues for non project members' do
+        get api("#{base_url}?state=opened", non_member)
+        expect_paginated_array_response(size: 1)
+        expect(json_response.first['title']).to eq(group_issue.title)
+      end
+      it 'returns group confidential issues for author' do
+        get api("#{base_url}?state=opened", author)
+        expect_paginated_array_response(size: 2)
+      end
+      it 'returns group confidential issues for assignee' do
+        get api("#{base_url}?state=opened", assignee)
+        expect_paginated_array_response(size: 2)
+      end
+      it 'returns group issues with confidential issues for project members' do
+        get api("#{base_url}?state=opened", user)
+        expect_paginated_array_response(size: 2)
+      end
+      it 'returns group confidential issues for admin' do
+        get api("#{base_url}?state=opened", admin)
+        expect_paginated_array_response(size: 2)
+      end
+      it 'returns an array of labeled group issues' do
+        get api("#{base_url}?labels=#{group_label.title}", user)
+        expect_paginated_array_response(size: 1)
+        expect(json_response.first['labels']).to eq([group_label.title])
+      end
+      it 'returns an array of labeled group issues where all labels match' do
+        get api("#{base_url}?labels=#{group_label.title},foo,bar", user)
+        expect_paginated_array_response(size: 0)
+      end
+      it 'returns issues matching given search string for title' do
+        get api("#{base_url}?search=#{group_issue.title}", user)
+        expect_paginated_array_response(size: 1)
+        expect(json_response.first['id']).to eq(group_issue.id)
+      end
+      it 'returns issues matching given search string for description' do
+        get api("#{base_url}?search=#{group_issue.description}", user)
+        expect_paginated_array_response(size: 1)
+        expect(json_response.first['id']).to eq(group_issue.id)
+      end
+      it 'returns an array of labeled issues when all labels matches' do
+        label_b = create(:label, title: 'foo', project: group_project)
+        label_c = create(:label, title: 'bar', project: group_project)
+        create(:label_link, label: label_b, target: group_issue)
+        create(:label_link, label: label_c, target: group_issue)
+        get api("#{base_url}", user), labels: "#{group_label.title},#{label_b.title},#{label_c.title}"
+        expect_paginated_array_response(size: 1)
+        expect(json_response.first['labels']).to eq([label_c.title, label_b.title, group_label.title])
+      end
+      it 'returns an array of issues found by iids' do
+        get api(base_url, user), iids: [group_issue.iid]
+        expect_paginated_array_response(size: 1)
+        expect(json_response.first['id']).to eq(group_issue.id)
+      end
+      it 'returns an empty array if iid does not exist' do
+        get api(base_url, user), iids: [99999]
+        expect_paginated_array_response(size: 0)
+      end
+      it 'returns an empty array if no group issue matches labels' do
+        get api("#{base_url}?labels=foo,bar", user)
+        expect_paginated_array_response(size: 0)
+      end
+      it 'returns an empty array if no issue matches milestone' do
+        get api("#{base_url}?milestone=#{group_empty_milestone.title}", user)
+        expect_paginated_array_response(size: 0)
+      end
+      it 'returns an empty array if milestone does not exist' do
+        get api("#{base_url}?milestone=foo", user)
+        expect_paginated_array_response(size: 0)
+      end
+      it 'returns an array of issues in given milestone' do
+        get api("#{base_url}?state=opened&milestone=#{group_milestone.title}", user)
+        expect_paginated_array_response(size: 1)
+        expect(json_response.first['id']).to eq(group_issue.id)
+      end
+      it 'returns an array of issues matching state in milestone' do
+        get api("#{base_url}?milestone=#{group_milestone.title}"\
+                '&state=closed', user)
+        expect_paginated_array_response(size: 1)
+        expect(json_response.first['id']).to eq(group_closed_issue.id)
+      end
+      it 'returns an array of issues with no milestone' do
+        get api("#{base_url}?milestone=#{no_milestone_title}", user)
+        expect(response).to have_gitlab_http_status(200)
+        expect_paginated_array_response(size: 1)
+        expect(json_response.first['id']).to eq(group_confidential_issue.id)
+      end
+      it 'sorts by created_at descending by default' do
+        get api(base_url, user)
+        response_dates = json_response.map { |issue| issue['created_at'] }
+        expect_paginated_array_response(size: 3)
+        expect(response_dates).to eq(response_dates.sort.reverse)
+      end
+      it 'sorts ascending when requested' do
+        get api("#{base_url}?sort=asc", user)
+        response_dates = json_response.map { |issue| issue['created_at'] }
+        expect_paginated_array_response(size: 3)
+        expect(response_dates).to eq(response_dates.sort)
+      end
+      it 'sorts by updated_at descending when requested' do
+        get api("#{base_url}?order_by=updated_at", user)
+        response_dates = json_response.map { |issue| issue['updated_at'] }
+        expect_paginated_array_response(size: 3)
+        expect(response_dates).to eq(response_dates.sort.reverse)
+      end
+
+      it 'sorts by updated_at ascending when requested' do
+        get api("#{base_url}?order_by=updated_at&sort=asc", user)
+
+        response_dates = json_response.map { |issue| issue['updated_at'] }
+
+        expect_paginated_array_response(size: 3)
+        expect(response_dates).to eq(response_dates.sort)
+      end
     end
   end
   describe "GET /projects/:id/issues" do
     let(:base_url) { "/projects/#{project.id}" }
+    context 'when unauthenticated' do
+      it 'returns public project issues' do
+        get api("/projects/#{project.id}/issues")
+
+        expect_paginated_array_response(size: 2)
+        expect(json_response.first['title']).to eq(issue.title)
+      end
+    end
+
     it 'avoids N+1 queries' do
       control_count = ActiveRecord::QueryRecorder.new do
         get api("/projects/#{project.id}/issues", user)
@@ -789,6 +829,14 @@ describe API::Issues do
   end
   describe "GET /projects/:id/issues/:issue_iid" do
+    context 'when unauthenticated' do
+      it 'returns public issues' do
+        get api("/projects/#{project.id}/issues/#{issue.iid}")
+
+        expect(response).to have_gitlab_http_status(200)
+      end
+    end
+
     it 'exposes known attributes' do
       get api("/projects/#{project.id}/issues/#{issue.iid}", user)
@@ -1581,6 +1629,14 @@ describe API::Issues do
       create(:merge_requests_closing_issues, issue: issue, merge_request: merge_request)
     end
+    context 'when unauthenticated' do
+      it 'return public project issues' do
+        get api("/projects/#{project.id}/issues/#{issue.iid}/closed_by")
+
+        expect_paginated_array_response(size: 1)
+      end
+    end
+
     it 'returns merge requests that will close issue on merge' do
       get api("/projects/#{project.id}/issues/#{issue.iid}/closed_by", user)
@@ -1605,6 +1661,14 @@ describe API::Issues do
   describe "GET /projects/:id/issues/:issue_iid/user_agent_detail" do
     let!(:user_agent_detail) { create(:user_agent_detail, subject: issue) }
+    context 'when unauthenticated' do
+      it "returns unautorized" do
+        get api("/projects/#{project.id}/issues/#{issue.iid}/user_agent_detail")
+
+        expect(response).to have_gitlab_http_status(401)
+      end
+    end
+
     it 'exposes known attributes' do
       get api("/projects/#{project.id}/issues/#{issue.iid}/user_agent_detail", admin)