Replace '.team << [user, role]' with 'add_role(user)' in specs

spec/features/dashboard/user_filters_projects_spec.rb

@@ -7,14 +7,14 @@ describe 'Dashboard > User filters projects' do
   let(:project2) { create(:project, name: 'Treasure', namespace: user2.namespace) }
   before do
-    project.team << [user, :master]
+    project.add_master(user)
     sign_in(user)
   end
   describe 'filtering personal projects' do
     before do
-      project2.team << [user, :developer]
+      project2.add_developer(user)
       visit dashboard_projects_path
     end

spec/features/global_search_spec.rb

@@ -5,7 +5,7 @@ feature 'Global search' do
   let(:project) { create(:project, namespace: user.namespace) }
   before do
-    project.team << [user, :master]
+    project.add_master(user)
     sign_in(user)
   end

spec/features/issues/award_emoji_spec.rb

@@ -11,7 +11,7 @@ describe 'Awards Emoji' do
   context 'authorized user' do
     before do
-      project.team << [user, :master]
+      project.add_master(user)
       sign_in(user)
     end

spec/features/issues/bulk_assignment_labels_spec.rb

@@ -11,7 +11,7 @@ feature 'Issues > Labels bulk assignment' do
   context 'as an allowed user', :js do
     before do
-      project.team << [user, :master]
+      project.add_master(user)
       sign_in user
     end

spec/features/issues/create_issue_for_discussions_in_merge_request_spec.rb

@@ -8,7 +8,7 @@ feature 'Resolving all open discussions in a merge request from an issue', :js d
   describe 'as a user with access to the project' do
     before do
-      project.team << [user, :master]
+      project.add_master(user)
       sign_in user
       visit project_merge_request_path(project, merge_request)
     end
@@ -81,7 +81,7 @@ feature 'Resolving all open discussions in a merge request from an issue', :js d
   describe 'as a reporter' do
     before do
-      project.team << [user, :reporter]
+      project.add_reporter(user)
       sign_in user
       visit new_project_issue_path(project, merge_request_to_resolve_discussions_of: merge_request.iid)
     end

spec/features/issues/create_issue_for_single_discussion_in_merge_request_spec.rb

@@ -8,7 +8,7 @@ feature 'Resolve an open discussion in a merge request by creating an issue' do
   describe 'As a user with access to the project' do
     before do
-      project.team << [user, :master]
+      project.add_master(user)
       sign_in user
       visit project_merge_request_path(project, merge_request)
     end
@@ -65,7 +65,7 @@ feature 'Resolve an open discussion in a merge request by creating an issue' do
   describe 'as a reporter' do
     before do
-      project.team << [user, :reporter]
+      project.add_reporter(user)
       sign_in user
       visit new_project_issue_path(project, merge_request_to_resolve_discussions_of: merge_request.iid,
                                             discussion_to_resolve: discussion.id)

spec/features/issues/filtered_search/dropdown_assignee_spec.rb

@@ -20,9 +20,9 @@ describe 'Dropdown assignee', :js do
   end
   before do
-    project.team << [user, :master]
-    project.team << [user_john, :master]
-    project.team << [user_jacob, :master]
+    project.add_master(user)
+    project.add_master(user_john)
+    project.add_master(user_jacob)
     sign_in(user)
     create(:issue, project: project)
@@ -222,7 +222,7 @@ describe 'Dropdown assignee', :js do
       expect(initial_size).to be > 0
       new_user = create(:user)
-      project.team << [new_user, :master]
+      project.add_master(new_user)
       find('.filtered-search-box .clear-search').click
       filtered_search.set('assignee')
       filtered_search.send_keys(':')

spec/features/issues/filtered_search/dropdown_author_spec.rb

@@ -28,9 +28,9 @@ describe 'Dropdown author', :js do
   end
   before do
-    project.team << [user, :master]
-    project.team << [user_john, :master]
-    project.team << [user_jacob, :master]
+    project.add_master(user)
+    project.add_master(user_john)
+    project.add_master(user_jacob)
     sign_in(user)
     create(:issue, project: project)
@@ -195,7 +195,7 @@ describe 'Dropdown author', :js do
       expect(initial_size).to be > 0
       new_user = create(:user)
-      project.team << [new_user, :master]
+      project.add_master(new_user)
       find('.filtered-search-box .clear-search').click
       filtered_search.set('author')
       send_keys_to_filtered_search(':')

spec/features/issues/filtered_search/dropdown_emoji_spec.rb

@@ -28,7 +28,7 @@ describe 'Dropdown emoji', :js do
   end
   before do
-    project.team << [user, :master]
+    project.add_master(user)
     create_list(:award_emoji, 2, user: user, name: 'thumbsup')
     create_list(:award_emoji, 1, user: user, name: 'thumbsdown')
     create_list(:award_emoji, 3, user: user, name: 'star')

spec/features/issues/filtered_search/dropdown_hint_spec.rb

@@ -13,7 +13,7 @@ describe 'Dropdown hint', :js do
   end
   before do
-    project.team << [user, :master]
+    project.add_master(user)
     create(:issue, project: project)
   end

spec/features/issues/filtered_search/dropdown_milestone_spec.rb

@@ -29,7 +29,7 @@ describe 'Dropdown milestone', :js do
   end
   before do
-    project.team << [user, :master]
+    project.add_master(user)
     sign_in(user)
     create(:issue, project: project)

spec/features/issues/filtered_search/search_bar_spec.rb

@@ -8,7 +8,7 @@ describe 'Search bar', :js do
   let(:filtered_search) { find('.filtered-search') }
   before do
-    project.team << [user, :master]
+    project.add_master(user)
     sign_in(user)
     create(:issue, project: project)

spec/features/issues/form_spec.rb

@@ -13,8 +13,8 @@ describe 'New/edit issue', :js do
   let!(:issue)     { create(:issue, project: project, assignees: [user], milestone: milestone) }
   before do
-    project.team << [user, :master]
-    project.team << [user2, :master]
+    project.add_master(user)
+    project.add_master(user2)
     sign_in(user)
   end

spec/features/issues/gfm_autocomplete_spec.rb

@@ -7,7 +7,7 @@ feature 'GFM autocomplete', :js do
   let(:issue)   { create(:issue, project: project) }
   before do
-    project.team << [user, :master]
+    project.add_master(user)
     sign_in(user)
     visit project_issue_path(project, issue)

spec/features/issues/issue_sidebar_spec.rb

@@ -18,7 +18,7 @@ feature 'Issue Sidebar' do
     let(:issue2) { create(:issue, project: project, author: user2) }
     before do
-      project.team << [user, :developer]
+      project.add_developer(user)
       visit_issue(project, issue2)
       find('.block.assignee .edit-link').click
@@ -78,7 +78,7 @@ feature 'Issue Sidebar' do
   context 'as a allowed user' do
     before do
-      project.team << [user, :developer]
+      project.add_developer(user)
       visit_issue(project, issue)
     end
@@ -156,7 +156,7 @@ feature 'Issue Sidebar' do
   context 'as a guest' do
     before do
-      project.team << [user, :guest]
+      project.add_guest(user)
       visit_issue(project, issue)
     end

spec/features/issues/move_spec.rb

@@ -13,7 +13,7 @@ feature 'issue move to another project' do
   context 'user does not have permission to move issue' do
     background do
-      old_project.team << [user, :guest]
+      old_project.add_guest(user)
       visit issue_path(issue)
     end
@@ -31,8 +31,8 @@ feature 'issue move to another project' do
     let(:cross_reference) { old_project.to_reference(new_project) }
     background do
-      old_project.team << [user, :reporter]
-      new_project.team << [user, :reporter]
+      old_project.add_reporter(user)
+      new_project.add_reporter(user)
       visit issue_path(issue)
     end
@@ -50,7 +50,7 @@ feature 'issue move to another project' do
     end
     scenario 'searching project dropdown', :js do
-      new_project_search.team << [user, :reporter]
+      new_project_search.add_reporter(user)
       find('.js-move-issue').click
       wait_for_requests
@@ -66,7 +66,7 @@ feature 'issue move to another project' do
     context 'user does not have permission to move the issue to a project', :js do
       let!(:private_project) { create(:project, :private) }
       let(:another_project) { create(:project) }
-      background { another_project.team << [user, :guest] }
+      background { another_project.add_guest(user) }
       scenario 'browsing projects in projects select' do
         find('.js-move-issue').click

spec/features/issues/notes_on_issues_spec.rb

@@ -8,7 +8,7 @@ describe 'Create notes on issues', :js do
     let(:note_text) { "Check #{mention.to_reference}" }
     before do
-      project.team << [user, :developer]
+      project.add_developer(user)
       sign_in(user)
       visit project_issue_path(project, issue)

spec/features/issues/spam_issues_spec.rb

@@ -17,7 +17,7 @@ describe 'New issue', :js do
       recaptcha_private_key: 'test private key'
     )
-    project.team << [user, :master]
+    project.add_master(user)
     sign_in(user)
   end

spec/features/issues/todo_spec.rb

@@ -6,7 +6,7 @@ feature 'Manually create a todo item from issue', :js do
   let!(:user)    { create(:user)}
   before do
-    project.team << [user, :master]
+    project.add_master(user)
     sign_in(user)
     visit project_issue_path(project, issue)
   end

spec/features/issues/update_issues_spec.rb

@@ -6,7 +6,7 @@ feature 'Multiple issue updating from issues#index', :js do
   let!(:user)      { create(:user)}
   before do
-    project.team << [user, :master]
+    project.add_master(user)
     sign_in(user)
   end