Skip to content
Snippets Groups Projects
Commit 2c37fa38 authored by Sergey Linnik's avatar Sergey Linnik
Browse files

fix some glitches in gravatar image url generation

always use proper size value
do not show alt text when avatar image not loaded
parent 552c2d66
No related branches found
No related tags found
1 merge request!2007allow customize gravatar url
Loading
Loading
@@ -76,7 +76,7 @@ class CommitDecorator < ApplicationDecorator
source_name = send "#{options[:source]}_name".to_sym
source_email = send "#{options[:source]}_email".to_sym
text = if options[:avatar]
avatar = h.image_tag h.gravatar_icon(source_email, options[:size]), class: "avatar #{"s#{options[:size]}" if options[:size]}", width: options[:size]
avatar = h.image_tag h.gravatar_icon(source_email, options[:size]), class: "avatar #{"s#{options[:size]}" if options[:size]}", width: options[:size], alt: ""
%Q{#{avatar} <span class="commit-#{options[:source]}-name">#{source_name}</span>}
else
source_name
Loading
Loading
Loading
Loading
@@ -30,7 +30,9 @@ module ApplicationHelper
args.any? { |v| v.to_s.downcase == action_name }
end
 
def gravatar_icon(user_email = '', size = 40)
def gravatar_icon(user_email = '', size = nil)
size = 40 if size.nil? || size <= 0
if Gitlab.config.disable_gravatar? || user_email.blank?
'no_avatar.png'
else
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment