Skip to content
Snippets Groups Projects
Commit 317ef7b5 authored by Phil Hughes's avatar Phil Hughes
Browse files

Fixed failing JS specs

parent 8198d498
No related branches found
No related tags found
No related merge requests found
Loading
Loading
@@ -76,7 +76,6 @@
}
 
static getSearchInput(filteredSearchInput) {
const selectionStart = filteredSearchInput.selectionStart;
const inputValue = filteredSearchInput.value;
const { right } = gl.DropdownUtils.getInputSelectionPosition(filteredSearchInput);
 
Loading
Loading
@@ -88,7 +87,7 @@
let inputValue = input.value;
// Replace all spaces inside quote marks with underscores
// This helps with matching the beginning & end of a token:key
inputValue = inputValue.replace(/"(.*?)"/g, str => str.replace(/\s/g, '_') );
inputValue = inputValue.replace(/"(.*?)"/g, str => str.replace(/\s/g, '_'));
 
// Get the right position for the word selected
// Regex matches first space
Loading
Loading
Loading
Loading
@@ -73,7 +73,6 @@
// Sometimes can end up at end of input
input.setSelectionRange(selectionStart, selectionStart);
 
const inputValue = input.value;
const { right } = gl.DropdownUtils.getInputSelectionPosition(input);
 
input.setSelectionRange(right, right);
Loading
Loading
Loading
Loading
@@ -67,20 +67,32 @@
});
 
describe('filterHint', () => {
let input;
beforeEach(() => {
setFixtures(`
<input type="text" id="test" />
`);
input = document.getElementById('test');
});
it('should filter', () => {
let updatedItem = gl.DropdownUtils.filterHint({
input.value = 'l';
let updatedItem = gl.DropdownUtils.filterHint(input, {
hint: 'label',
}, 'l');
});
expect(updatedItem.droplab_hidden).toBe(false);
 
updatedItem = gl.DropdownUtils.filterHint({
input.value = 'o';
updatedItem = gl.DropdownUtils.filterHint(input, {
hint: 'label',
}, 'o');
expect(updatedItem.droplab_hidden).toBe(true);
});
 
it('should return droplab_hidden false when item has no hint', () => {
const updatedItem = gl.DropdownUtils.filterHint({}, '');
const updatedItem = gl.DropdownUtils.filterHint(input, {}, '');
expect(updatedItem.droplab_hidden).toBe(false);
});
});
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment