Revert "Merge branch 'tz-mr-refactor-mem-posting' into 'master'"

This reverts commit 9c121352, reversing
changes made to c1b335e0.

app/assets/javascripts/lib/utils/poll.js

@@ -63,7 +63,6 @@ export default class Poll {
     const headers = normalizeHeaders(response.headers);
     const pollInterval = parseInt(headers[this.intervalHeader], 10);
     if (pollInterval > 0 && successCodes.indexOf(response.status) !== -1 && this.canPoll) {
-      clearTimeout(this.timeoutID);
       this.timeoutID = setTimeout(() => {
         this.makeRequest();
       }, pollInterval);

app/assets/javascripts/notes/stores/mutations.js

@@ -174,19 +174,27 @@ export default {
   [types.UPDATE_NOTE](state, note) {
     const noteObj = utils.findNoteObjectById(state.discussions, note.discussion_id);
+
     if (noteObj.individual_note) {
       noteObj.notes.splice(0, 1, note);
     } else {
       const comment = utils.findNoteObjectById(noteObj.notes, note.id);
-      Object.assign(comment, note);
+      noteObj.notes.splice(noteObj.notes.indexOf(comment), 1, note);
     }
   },
   [types.UPDATE_DISCUSSION](state, noteData) {
     const note = noteData;
-    const selectedDiscussion = state.discussions.find(n => n.id === note.id);
+    let index = 0;
+
+    state.discussions.forEach((n, i) => {
+      if (n.id === note.id) {
+        index = i;
+      }
+    });
+
     note.expanded = true; // override expand flag to prevent collapse
-    Object.assign(selectedDiscussion, note);
+    state.discussions.splice(index, 1, note);
   },
   [types.CLOSE_ISSUE](state) {
@@ -207,9 +215,12 @@ export default {
   [types.SET_DISCUSSION_DIFF_LINES](state, { discussionId, diffLines }) {
     const discussion = utils.findNoteObjectById(state.discussions, discussionId);
-    Object.assign(discussion, {
+    const index = state.discussions.indexOf(discussion);
+    const discussionWithDiffLines = Object.assign({}, discussion, {
       truncated_diff_lines: diffLines,
     });
+
+    state.discussions.splice(index, 1, discussionWithDiffLines);
   },
 };

app/assets/javascripts/notes/stores/utils.js

@@ -2,11 +2,13 @@ import AjaxCache from '~/lib/utils/ajax_cache';
 const REGEX_QUICK_ACTIONS = /^\/\w+.*$/gm;
-export const findNoteObjectById = (notes, id) => notes.find(n => n.id === id);
+export const findNoteObjectById = (notes, id) =>
+  notes.filter(n => n.id === id)[0];
 export const getQuickActionText = note => {
   let text = 'Applying command';
-  const quickActions = AjaxCache.get(gl.GfmAutoComplete.dataSources.commands) || [];
+  const quickActions =
+    AjaxCache.get(gl.GfmAutoComplete.dataSources.commands) || [];
   const executedCommands = quickActions.filter(command => {
     const commandRegex = new RegExp(`/${command.name}`);
@@ -27,4 +29,5 @@ export const getQuickActionText = note => {
 export const hasQuickActions = note => REGEX_QUICK_ACTIONS.test(note);
-export const stripQuickActions = note => note.replace(REGEX_QUICK_ACTIONS, '').trim();
+export const stripQuickActions = note =>
+  note.replace(REGEX_QUICK_ACTIONS, '').trim();