Skip to content
Snippets Groups Projects
Commit 33c51327 authored by Matt Humphrey's avatar Matt Humphrey
Browse files

Fix RESTfulness of project hook deletions by API

parent b7ac654b
No related branches found
No related tags found
1 merge request!3053Fix RESTfulness of project hook deletions by API
Loading
Loading
@@ -265,7 +265,7 @@ Will return status `201 Created` on success, or `404 Not found` on fail.
Delete hook from project
 
```
DELETE /projects/:id/hooks
DELETE /projects/:id/hooks/:hook_id
```
 
Parameters:
Loading
Loading
Loading
Loading
@@ -205,8 +205,8 @@ module Gitlab
# id (required) - The ID of a project
# hook_id (required) - The ID of hook to delete
# Example Request:
# DELETE /projects/:id/hooks
delete ":id/hooks" do
# DELETE /projects/:id/hooks/:hook_id
delete ":id/hooks/:hook_id" do
authorize! :admin_project, user_project
@hook = user_project.hooks.find(params[:hook_id])
@hook.destroy
Loading
Loading
Loading
Loading
@@ -275,11 +275,10 @@ describe Gitlab::API do
end
end
 
describe "DELETE /projects/:id/hooks" do
describe "DELETE /projects/:id/hooks/:hook_id" do
it "should delete hook from project" do
expect {
delete api("/projects/#{project.id}/hooks", user),
delete api("/projects/#{project.id}/hooks/#{hook.id}", user),
hook_id: hook.id
}.to change {project.hooks.count}.by(-1)
end
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment